NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit870ad6a

committed

Fix not-quite-right string comparison in parse_jsonb_index_flags().

This code would accept "strinX", where X is any 1-byte character,as meaning "string". Clearly it wasn't meant to do that.No back-patch, since this doesn't affect correct queries andthere's some tiny chance we'd break somebody's incorrect queryin a minor release.Report and patch by Dominik Czarnota.Discussion:https://postgr.es/m/CABEVAa1dU0mDCAfaT8WF2adVXTDsLVJy_izotg6ze_hh-cn8qQ@mail.gmail.com

1 parent74b35eb commit870ad6aCopy full SHA for 870ad6a

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- jsonfuncs.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/jsonfuncs.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5125,7 +5125,7 @@ parse_jsonb_index_flags(Jsonb *jb)`
`5125`	`5125`	`pg_strncasecmp(v.val.string.val,"key",3)==0)`
`5126`	`5126`	`flags \|=jtiKey;`
`5127`	`5127`	`elseif (v.val.string.len==6&&`
`5128`		`-pg_strncasecmp(v.val.string.val,"string",5)==0)`
	`5128`	`+pg_strncasecmp(v.val.string.val,"string",6)==0)`
`5129`	`5129`	`flags \|=jtiString;`
`5130`	`5130`	`elseif (v.val.string.len==7&&`
`5131`	`5131`	`pg_strncasecmp(v.val.string.val,"numeric",7)==0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit870ad6a

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/jsonfuncs.c`

0 commit comments