Commit86749ea

committed

Improve generated_stored test

It makes more sense to put the catalog sanity check at the end of thetest rather than at the beginning, so that it can also check whateverthe tests did rather than just whatever happened before the tests.Suggested-by: jian he <jian.universality@gmail.com>Discussion:https://www.postgresql.org/message-id/flat/a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org

1 parent443a8e4 commit86749eaCopy full SHA for 86749ea

File tree

+10

-10

lines changed

+10

-10

lines changed

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,3 @@`
`1`		`--- sanity check of system catalog`
`2`		`-SELECT attrelid, attname, attgenerated FROM pg_attribute WHERE attgenerated NOT IN ('', 's');`
`3`		`- attrelid \| attname \| attgenerated`
`4`		`-----------+---------+--------------`
`5`		`-(0 rows)`
`6`		`-`
`7`	`1`	`CREATE SCHEMA generated_stored_tests;`
`8`	`2`	`GRANT USAGE ON SCHEMA generated_stored_tests TO PUBLIC;`
`9`	`3`	`SET search_path = generated_stored_tests;`
`@@ -1356,3 +1350,9 @@ CREATE TABLE gtest28b (LIKE gtest28a INCLUDING GENERATED);`
`1356`	`1350`	`c \| integer \| \| \|`
`1357`	`1351`	`x \| integer \| \| \| generated always as (b * 2) stored`
`1358`	`1352`
	`1353`	`+-- sanity check of system catalog`
	`1354`	`+SELECT attrelid, attname, attgenerated FROM pg_attribute WHERE attgenerated NOT IN ('', 's');`
	`1355`	`+ attrelid \| attname \| attgenerated`
	`1356`	`+----------+---------+--------------`
	`1357`	`+(0 rows)`
	`1358`	`+`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,3 @@`
`1`		`--- sanity check of system catalog`
`2`		`-SELECT attrelid, attname, attgeneratedFROM pg_attributeWHERE attgenerated NOTIN ('','s');`
`3`		`-`
`4`		`-`
`5`	`1`	`CREATESCHEMAgenerated_stored_tests;`
`6`	`2`	`GRANT USAGEON SCHEMA generated_stored_tests TO PUBLIC;`
`7`	`3`	`SET search_path= generated_stored_tests;`
`@@ -675,3 +671,7 @@ ALTER TABLE gtest28a DROP COLUMN a;`
`675`	`671`	`CREATETABLEgtest28b (LIKE gtest28a INCLUDING GENERATED);`
`676`	`672`
`677`	`673`	`\d gtest28*`
	`674`	`+`
	`675`	`+`
	`676`	`+-- sanity check of system catalog`
	`677`	`+SELECT attrelid, attname, attgeneratedFROM pg_attributeWHERE attgenerated NOTIN ('','s');`

Comments

(0)