NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit86705aa

committed

Allow a foreign table CHECK constraint to be initially NOT VALID.

For a table, the constraint can be considered validated immediately,because the table must be empty. But for a foreign table this isnot necessarily the case.Fixes a bug in commitf27a6b1.Amit Langote, with some changes by me.Discussion:http://postgr.es/m/d2b7419f-4a71-cf86-cc99-bfd0f359a1ea@lab.ntt.co.jp

1 parent12a34f5 commit86705aaCopy full SHA for 86705aa

File tree

1 file changed

-4

lines changed

src/backend/parser
- parse_utilcmd.c

1 file changed

-4

lines changed

`‎src/backend/parser/parse_utilcmd.c`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,6 +165,7 @@ transformCreateStmt(CreateStmt stmt, const char queryString)`
`165`	`165`	`Oidexisting_relid;`
`166`	`166`	`ParseCallbackStatepcbstate;`
`167`	`167`	`boollike_found= false;`
	`168`	`+boolis_foreign_table=IsA(stmt,CreateForeignTableStmt);`
`168`	`169`
`169`	`170`	`/*`
`170`	`171`	`* We must not scribble on the passed-in CreateStmt, so copy it. (This is`
`@@ -330,7 +331,7 @@ transformCreateStmt(CreateStmt stmt, const char queryString)`
`330`	`331`	`/*`
`331`	`332`	`* Postprocess check constraints.`
`332`	`333`	`*/`
`333`		`-transformCheckConstraints(&cxt, true);`
	`334`	`+transformCheckConstraints(&cxt,!is_foreign_table ?true : false);`
`334`	`335`
`335`	`336`	`/*`
`336`	`337`	`* Output results.`
`@@ -2129,9 +2130,9 @@ transformCheckConstraints(CreateStmtContext *cxt, bool skipValidation)`
`2129`	`2130`	`return;`
`2130`	`2131`
`2131`	`2132`	`/*`
`2132`		`- * If creating a new table, we can safely skip validation of check`
`2133`		`- * constraints, and nonetheless mark them valid. (This will override any`
`2134`		`- * user-supplied NOT VALID flag.)`
	`2133`	`+ * If creating a new table (but not a foreign table), we can safely skip`
	`2134`	`+ *validation of checkconstraints, and nonetheless mark them valid.`
	`2135`	`+ *(This will override anyuser-supplied NOT VALID flag.)`
`2135`	`2136`	`*/`
`2136`	`2137`	`if (skipValidation)`
`2137`	`2138`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit86705aa

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_utilcmd.c`

0 commit comments