Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit861ad67

Browse files
committed
pg_upgrade: remove --single-transaction usage
With AtEOXact applied, --single-transaction makes pg_restore slower, andhas the potential to require lock table configuration, so remove theargument.Per suggestion from Tom.
1 parent21c87a0 commit861ad67

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

‎contrib/pg_upgrade/pg_upgrade.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -314,12 +314,11 @@ create_new_objects(void)
314314
snprintf(log_file_name,sizeof(log_file_name),DB_DUMP_LOG_FILE_MASK,old_db->db_oid);
315315

316316
/*
317-
*Using pg_restore --single-transaction is faster than other
318-
*methods, like --jobs. pg_dump only produces its output at the
319-
*end, so there is little parallelism using the pipe.
317+
*pg_dump only produces its output at the end, so there is little
318+
*parallelism if using the pipe.
320319
*/
321320
parallel_exec_prog(log_file_name,NULL,
322-
"\"%s/pg_restore\" %s --exit-on-error --single-transaction --verbose --dbname \"%s\" \"%s\"",
321+
"\"%s/pg_restore\" %s --exit-on-error --verbose --dbname \"%s\" \"%s\"",
323322
new_cluster.bindir,cluster_conn_opts(&new_cluster),
324323
old_db->db_name,sql_file_name);
325324
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp