NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit85d0e66

committed

Make recovery_target_action = pause work.

Previously even if recovery_target_action was set to pause andthe recovery target was reached, the recovery could never be paused.Because the setting of pause was *always* overridden with that ofshutdown unexpectedly. This override is valid and intentionalif hot_standby is not enabled because there is no way to resumethe paused recovery in this case and the setting of pause iscompletely useless. But not if hot_standby is enabled.This patch changes the code so that the setting of pause is overriddenwith that of shutdown only when hot_standby is not enabled.Bug reported by Andres Freund

1 parenta6a66bd commit85d0e66Copy full SHA for 85d0e66

File tree

1 file changed

-2

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-2

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5141,8 +5141,8 @@ readRecoveryCommandFile(void)`
`5141`	`5141`	`*/`
`5142`	`5142`	`if (recoveryTargetAction==RECOVERY_TARGET_ACTION_PAUSE&&`
`5143`	`5143`	`recoveryTargetActionSet&&`
`5144`		`-standbyState==STANDBY_DISABLED)`
`5145`		`-recoveryTargetAction=RECOVERY_TARGET_ACTION_SHUTDOWN;`
	`5144`	`+!EnableHotStandby)`
	`5145`	`+recoveryTargetAction=RECOVERY_TARGET_ACTION_SHUTDOWN;`
`5146`	`5146`
`5147`	`5147`	`/* Enable fetching from archive recovery area */`
`5148`	`5148`	`ArchiveRecoveryRequested= true;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit85d0e66

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments