NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit85c2b9a

committed

Code review of get_qual_for_list.

We need not consider the case where both nulltest1 and nulltest2 areNULL; the partition either accepts nulls or it does not.Jeevan Ladhe. I added an assertion.

1 parent9ae2661 commit85c2b9aCopy full SHA for 85c2b9a

File tree

1 file changed

-3

lines changed

src/backend/catalog
- partition.c

1 file changed

-3

lines changed

`‎src/backend/catalog/partition.c`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1383,15 +1383,14 @@ get_qual_for_list(PartitionKey key, PartitionBoundSpec *spec)`
`1383`	`1383`
`1384`	`1384`	`if (nulltest1)`
`1385`	`1385`	`result=list_make2(nulltest1,opexpr);`
`1386`		`-elseif (nulltest2)`
	`1386`	`+else`
`1387`	`1387`	`{`
`1388`	`1388`	`Expr*or;`
`1389`	`1389`
	`1390`	`+Assert(nulltest2!=NULL);`
`1390`	`1391`	`or=makeBoolExpr(OR_EXPR,list_make2(nulltest2,opexpr),-1);`
`1391`	`1392`	`result=list_make1(or);`
`1392`	`1393`	`}`
`1393`		`-else`
`1394`		`-result=list_make1(opexpr);`
`1395`	`1394`
`1396`	`1395`	`returnresult;`
`1397`	`1396`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit85c2b9a

File tree

1 file changed

1 file changed

`‎src/backend/catalog/partition.c`

0 commit comments