NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit85837b8

committed

Fix handling of NULL return value in typarray lookup

Commit6ebeeae accidentally omitted testing the return value fromfindTypeByOid which can return NULL. Fix by adding a check to makesure that we have a pointer to dereference.Author: Ranier Vilela <ranier.vf@gmail.com>Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>Reviewed-by: Daniel Gustafsson <daniel@yesql.se>Discussion:https://postgr.es/m/CAEudQAqfMTH8Ya_J6E-NW_y_JyDFDxtQ4V_g6nY_1=0oDbQqdg@mail.gmail.com

1 parent4af123a commit85837b8Copy full SHA for 85837b8

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5420,7 +5420,10 @@ binary_upgrade_set_type_oids_by_type_oid(Archive *fout,`
`5420`	`5420`	`pg_type_oid);`
`5421`	`5421`
`5422`	`5422`	`tinfo = findTypeByOid(pg_type_oid);`
`5423`		`-pg_type_array_oid = tinfo->typarray;`
	`5423`	`+if (tinfo)`
	`5424`	`+pg_type_array_oid = tinfo->typarray;`
	`5425`	`+else`
	`5426`	`+pg_type_array_oid = InvalidOid;`
`5424`	`5427`
`5425`	`5428`	`if (!OidIsValid(pg_type_array_oid) && force_array_type)`
`5426`	`5429`	`pg_type_array_oid = get_next_possible_free_pg_type_oid(fout, upgrade_query);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit85837b8

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments