NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8565808

committed

Fix order of arguments to SubTransSetParent().

ProcessTwoPhaseBuffer (formerly StandbyRecoverPreparedTransactions)mixed up the parent and child XIDs when calling SubTransSetParent torecord the transactions' relationship in pg_subtrans.Remarkably, analysis by Simon Riggs suggests that this doesn't lead tovisible problems (at least, not in non-Assert builds). That mightexplain why we'd not noticed it before. Nonetheless, it's surely wrong.This code was born broken, so back-patch to all supported branches.Discussion:https://postgr.es/m/20110.1492905318@sss.pgh.pa.us

1 parent38a6e57 commit8565808Copy full SHA for 8565808

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- twophase.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/twophase.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1922,7 +1922,7 @@ StandbyRecoverPreparedTransactions(bool overwriteOK)`
`1922`	`1922`	`TransactionIdsubxid=subxids[i];`
`1923`	`1923`
`1924`	`1924`	`Assert(TransactionIdFollows(subxid,xid));`
`1925`		`-SubTransSetParent(xid,subxid,overwriteOK);`
	`1925`	`+SubTransSetParent(subxid,xid,overwriteOK);`
`1926`	`1926`	`}`
`1927`	`1927`	`}`
`1928`	`1928`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8565808

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/twophase.c`

0 commit comments