Commit851ff93

committed

Fix hash_array

Commita3d2b1b neglected toinitialize the type_id field of the synthesized type cache entry, soit would make a new one on every call.Also, better use the per-function memory context for this; otherwiseit leaks memory.Discussion:https://www.postgresql.org/message-id/flat/17158-8a2ba823982537a4%40postgresql.org

1 parent379591f commit851ff93Copy full SHA for 851ff93

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3992,13 +3992,14 @@ hash_array(PG_FUNCTION_ARGS)`
`3992`	`3992`	`MemoryContextoldcontext;`
`3993`	`3993`	`TypeCacheEntry*record_typentry;`
`3994`	`3994`
`3995`		`-oldcontext=MemoryContextSwitchTo(CacheMemoryContext);`
	`3995`	`+oldcontext=MemoryContextSwitchTo(fcinfo->flinfo->fn_mcxt);`
`3996`	`3996`
`3997`	`3997`	`/*`
`3998`	`3998`	`* Make fake type cache entry structure. Note that we can't just`
`3999`	`3999`	`* modify typentry, since that points directly into the type cache.`
`4000`	`4000`	`*/`
`4001`		`-record_typentry=palloc(sizeof(*record_typentry));`
	`4001`	`+record_typentry=palloc0(sizeof(*record_typentry));`
	`4002`	`+record_typentry->type_id=element_type;`
`4002`	`4003`
`4003`	`4004`	`/* fill in what we need below */`
`4004`	`4005`	`record_typentry->typlen=typentry->typlen;`

Comments

(0)