NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit84dbd5a

committed

Disallow SETOF in the input of parseTypeString(). Formerly it was

silently ignored, allowing one to write bizarre things likeDECLARE x setof int;in plpgsql. This has misled at least one novice into thinking thatplpgsql variables could be sets ...

1 parentc3d6c7d commit84dbd5aCopy full SHA for 84dbd5a

File tree

1 file changed

-1

lines changed

src/backend/parser
- parse_type.c

1 file changed

-1

lines changed

`‎src/backend/parser/parse_type.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/parser/parse_type.c,v 1.71 2004/08/29 05:06:44 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/parser/parse_type.c,v 1.72 2004/12/15 20:15:17 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -453,6 +453,8 @@ parseTypeString(const char str, Oid type_id, int32 *typmod)`
`453`	`453`	`if (typename==NULL\|\|`
`454`	`454`	`!IsA(typename,TypeName))`
`455`	`455`	`gotofail;`
	`456`	`+if (typename->setof)`
	`457`	`+gotofail;`
`456`	`458`
`457`	`459`	`*type_id=typenameTypeId(typename);`
`458`	`460`	`*typmod=typename->typmod;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit84dbd5a

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_type.c`

0 commit comments