NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit84db516

committed

Fix one-off bug causing missing commit timestamps for subtransactions

The logic in charge of writing commit timestamps (enabled withtrack_commit_timestamp) for subtransactions had a one-bug bug,where it would be possible that commit timestamps go missing for thelast subtransaction committed.While on it, simplify a bit the iteration logic in the loop writing thecommit timestamps, as per suggestions from Kyotaro Horiguchi and TomLane, so as some variable initializations are not part of the loopitself.Issue introduced in73c986a.Analyzed-by: Alex KingsboroughAuthor: Alex Kingsborough, Kyotaro HoriguchiDiscussion:https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.comBackpatch-through: 10

1 parentcf680bd commit84db516Copy full SHA for 84db516

File tree

1 file changed

-3

lines changed

src/backend/access/transam
- commit_ts.c

1 file changed

-3

lines changed

`‎src/backend/access/transam/commit_ts.c`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,9 @@ TransactionTreeSetCommitTsData(TransactionId xid, int nsubxids,`
`167`	`167`	`* subxid not on the previous page as head. This way, we only have to`
`168`	`168`	`* lock/modify each SLRU page once.`
`169`	`169`	`*/`
`170`		`-for (i=0,headxid=xid;;)`
	`170`	`+headxid=xid;`
	`171`	`+i=0;`
	`172`	`+for (;;)`
`171`	`173`	`{`
`172`	`174`	`intpageno=TransactionIdToCTsPage(headxid);`
`173`	`175`	`intj;`
`@@ -183,15 +185,15 @@ TransactionTreeSetCommitTsData(TransactionId xid, int nsubxids,`
`183`	`185`	`pageno);`
`184`	`186`
`185`	`187`	`/* if we wrote out all subxids, we're done. */`
`186`		`-if (j+1>=nsubxids)`
	`188`	`+if (j >=nsubxids)`
`187`	`189`	`break;`
`188`	`190`
`189`	`191`	`/*`
`190`	`192`	`* Set the new head and skip over it, as well as over the subxids we`
`191`	`193`	`* just wrote.`
`192`	`194`	`*/`
`193`	`195`	`headxid=subxids[j];`
`194`		`-i+=j-i+1;`
	`196`	`+i=j+1;`
`195`	`197`	`}`
`196`	`198`
`197`	`199`	`/* update the cached value in shared memory */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit84db516

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/commit_ts.c`

0 commit comments