NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8424dfc

committed

Avoid O(N^2) behavior when the standby process releases many locks.

When replaying a transaction that held many exclusive locks on theprimary, a standby server's startup process would expend O(N^2)effort on manipulating the list of locks. This code was fine whenwritten, but commit1cff1b9 made repetitive list_delete_first()calls inefficient, as explained in its commit message. Fix by justiterating the list normally, and releasing storage only when done.(This'd be inadequate if we needed to recover from an error occurringpartway through; but we don't.)Back-patch to v13 where1cff1b9 came in.Nathan BossartDiscussion:https://postgr.es/m/CD2F0E7F-9822-45EC-A411-AE56F14DEA9F@amazon.com

1 parentbd9f4cf commit8424dfcCopy full SHA for 8424dfc

File tree

1 file changed

-4

lines changed

src/backend/storage/ipc
- standby.c

1 file changed

-4

lines changed

`‎src/backend/storage/ipc/standby.c‎`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -986,9 +986,11 @@ StandbyAcquireAccessExclusiveLock(TransactionId xid, Oid dbOid, Oid relOid)`
`986`	`986`	`staticvoid`
`987`	`987`	`StandbyReleaseLockList(List*locks)`
`988`	`988`	`{`
`989`		`-while (locks)`
	`989`	`+ListCell*lc;`
	`990`	`+`
	`991`	`+foreach(lc,locks)`
`990`	`992`	`{`
`991`		`-xl_standby_locklock= (xl_standby_lock)linitial(locks);`
	`993`	`+xl_standby_locklock= (xl_standby_lock)lfirst(lc);`
`992`	`994`	`LOCKTAGlocktag;`
`993`	`995`
`994`	`996`	`elog(trace_recovery(DEBUG4),`
`@@ -1002,9 +1004,9 @@ StandbyReleaseLockList(List *locks)`
`1002`	`1004`	`lock->xid,lock->dbOid,lock->relOid);`
`1003`	`1005`	`Assert(false);`
`1004`	`1006`	`}`
`1005`		`-pfree(lock);`
`1006`		`-locks=list_delete_first(locks);`
`1007`	`1007`	`}`
	`1008`	`+`
	`1009`	`+list_free_deep(locks);`
`1008`	`1010`	`}`
`1009`	`1011`
`1010`	`1012`	`staticvoid`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8424dfc

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/standby.c‎`

0 commit comments