NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit840729f

committed

Fix incorrect xmlschema output for types timetz and timestamptz.

The output of table_to_xmlschema() and allied functions includesa regex describing valid values for these types ... but the regexwas itself invalid, as it failed to escape a literal "+" sign.Report and fix by Renan Soares Lopes. Back-patch to allsupported branches.Discussion:https://postgr.es/m/7f6fabaa-3f8f-49ab-89ca-59fbfe633105@me.com

1 parent1f5ef5a commit840729fCopy full SHA for 840729f

File tree

4 files changed

+514

-438

lines changed

src
- backend/utils/adt
  - xml.c
- test/regress
  - expected
    - xmlmap.out
    - xmlmap_1.out
  - sql
    - xmlmap.sql

4 files changed

+514

-438

lines changed

`‎src/backend/utils/adt/xml.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3673,7 +3673,7 @@ map_sql_type_to_xmlschema_type(Oid typeoid, int typmod)`
`3673`	`3673`	`caseTIMEOID:`
`3674`	`3674`	`caseTIMETZOID:`
`3675`	`3675`	`{`
`3676`		`-constchar*tz= (typeoid==TIMETZOID ?"(+\|-)\\p{Nd}{2}:\\p{Nd}{2}" :"");`
	`3676`	`+constchar*tz= (typeoid==TIMETZOID ?"(\\+\|-)\\p{Nd}{2}:\\p{Nd}{2}" :"");`
`3677`	`3677`
`3678`	`3678`	`if (typmod==-1)`
`3679`	`3679`	`appendStringInfo(&result,`
`@@ -3696,7 +3696,7 @@ map_sql_type_to_xmlschema_type(Oid typeoid, int typmod)`
`3696`	`3696`	`caseTIMESTAMPOID:`
`3697`	`3697`	`caseTIMESTAMPTZOID:`
`3698`	`3698`	`{`
`3699`		`-constchar*tz= (typeoid==TIMESTAMPTZOID ?"(+\|-)\\p{Nd}{2}:\\p{Nd}{2}" :"");`
	`3699`	`+constchar*tz= (typeoid==TIMESTAMPTZOID ?"(\\+\|-)\\p{Nd}{2}:\\p{Nd}{2}" :"");`
`3700`	`3700`
`3701`	`3701`	`if (typmod==-1)`
`3702`	`3702`	`appendStringInfo(&result,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit840729f

File tree

4 files changed

4 files changed

`‎src/backend/utils/adt/xml.c`

0 commit comments