NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit83fbd9b

committed

Fix incorrect math in DetermineSafeOldestOffset.

The old formula didn't have enough parentheses, so it would do the wrongthing, and it used / rather than % to find a remainder. The effect ofthese oversights is that the stop point chosen by the logic introduced incommitb69bf30 might be rathermeaningless.Thomas Munro, reviewed by Kevin Grittner, with a whitespace tweak by me.

1 parentba3caee commit83fbd9bCopy full SHA for 83fbd9b

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- multixact.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/multixact.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2514,7 +2514,8 @@ DetermineSafeOldestOffset(MultiXactId oldestMXact)`
`2514`	`2514`	`*/`
`2515`	`2515`	`oldestOffset=find_multixact_start(oldestMXact);`
`2516`	`2516`	`/* move back to start of the corresponding segment */`
`2517`		`-oldestOffset-=oldestOffset /MULTIXACT_MEMBERS_PER_PAGE*SLRU_PAGES_PER_SEGMENT;`
	`2517`	`+oldestOffset-=oldestOffset %`
	`2518`	`+(MULTIXACT_MEMBERS_PER_PAGE*SLRU_PAGES_PER_SEGMENT);`
`2518`	`2519`
`2519`	`2520`	`LWLockAcquire(MultiXactGenLock,LW_EXCLUSIVE);`
`2520`	`2521`	`/* always leave one segment before the wraparound point */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit83fbd9b

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/multixact.c`

0 commit comments