Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit83f7761

Browse files
committed
Teach pg_ls_dir_files() to ignore ENOENT failures from stat().
Buildfarm experience shows that this function can fail with ENOENTif some other process unlinks a file between when we read the directoryentry and when we try to stat() it. The problem is old but we hadnot noticed it until085b6b6 added regression test coverage.To fix, just ignore ENOENT failures. There is one other case thatthis might hide: a symlink that points to nowhere. That seems okaythough, at least better than erroring.Back-patch to v10 where this function was added, since the regressiontest cases were too.Discussion:https://postgr.es/m/20200308173103.GC1357@telsasoft.com
1 parent8b902e4 commit83f7761

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

‎src/backend/utils/adt/genfile.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -538,9 +538,14 @@ pg_ls_dir_files(FunctionCallInfo fcinfo, const char *dir)
538538
/* Get the file info */
539539
snprintf(path,sizeof(path),"%s/%s",dir,de->d_name);
540540
if (stat(path,&attrib)<0)
541+
{
542+
/* Ignore concurrently-deleted files, else complain */
543+
if (errno==ENOENT)
544+
continue;
541545
ereport(ERROR,
542546
(errcode_for_file_access(),
543547
errmsg("could not stat file \"%s\": %m",path)));
548+
}
544549

545550
/* Ignore anything but regular files */
546551
if (!S_ISREG(attrib.st_mode))

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp