Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit83ed4de

Browse files
committed
Improve pg_basebackup long file name test Windows robustness
Creation of a file with a very long name can create problems on Windowsdue to its file path limits. Work around that by creating the file via asymlink with a shorter name.Error displayed by buildfarm animal fairywren.oBackpatch to all live branches
1 parentc8987ea commit83ed4de

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

‎src/bin/pg_basebackup/t/010_pg_basebackup.pl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,16 +203,20 @@
203203
'-T with invalid format fails');
204204

205205
# Tar format doesn't support filenames longer than 100 bytes.
206+
# Create the test file via a short name directory so it doesn't blow the
207+
# Windows path limit.
208+
my$lftmp = PostgreSQL::Test::Utils::tempdir_short;
209+
dir_symlink"$pgdata","$lftmp/pgdata";
206210
my$superlongname ="superlongname_" . ("x"x100);
207-
my$superlongpath ="$pgdata/$superlongname";
211+
my$superlongpath ="$lftmp/pgdata/$superlongname";
208212

209213
openmy$file,'>',"$superlongpath"
210214
ordie"unable to create file$superlongpath";
211215
close$file;
212216
$node->command_fails(
213217
['pg_basebackup','-D',"$tempdir/tarbackup_l1",'-Ft' ],
214218
'pg_basebackup tar with long name fails');
215-
unlink"$pgdata/$superlongname";
219+
unlink"$superlongpath";
216220

217221
# The following tests are for symlinks.
218222

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp