Commit8364510

committed

Allow background workers to connect to no particular database.

The documentation claims that this is supported, but it didn'tactually work. Fix that.Reported by Pavel Stehule; patch by me.

1 parente118555 commit8364510Copy full SHA for 8364510

File tree

+13

-1

lines changed

+13

-1

lines changed

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -798,7 +798,7 @@ InitPostgres(const char in_dbname, Oid dboid, const char username,`
`798`	`798`	`/* take database name from the caller, just for paranoia */`
`799`	`799`	`strlcpy(dbname,in_dbname,sizeof(dbname));`
`800`	`800`	`}`
`801`		`-else`
	`801`	`+elseif (OidIsValid(dboid))`
`802`	`802`	`{`
`803`	`803`	`/* caller specified database by OID */`
`804`	`804`	`HeapTupletuple;`
`@@ -818,6 +818,18 @@ InitPostgres(const char in_dbname, Oid dboid, const char username,`
`818`	`818`	`if (out_dbname)`
`819`	`819`	`strcpy(out_dbname,dbname);`
`820`	`820`	`}`
	`821`	`+else`
	`822`	`+{`
	`823`	`+/*`
	`824`	`+ * If this is a background worker not bound to any particular`
	`825`	`+ * database, we're done now. Everything that follows only makes`
	`826`	`+ * sense if we are bound to a specific database. We do need to`
	`827`	`+ * close the transaction we started before returning.`
	`828`	`+ */`
	`829`	`+if (!bootstrap)`
	`830`	`+CommitTransactionCommand();`
	`831`	`+return;`
	`832`	`+}`
`821`	`833`
`822`	`834`	`/*`
`823`	`835`	`* Now, take a writer's lock on the database we are trying to connect to.`

Comments

(0)