Commit834fce5

committed

Improve error message with JSON_SERIALIZE()

The error message introduced in3c633f3 can share the same format stringwith an existing message used for JSON(), reducing the translationeffort.Author: Kyotaro HoriguchiDiscussion:https://postgr.es/m/20220708.154135.2123613118233840495.horikyota.ntt@gmail.comBackpatch-through: 15

1 parentb2b6c1b commit834fce5Copy full SHA for 834fce5

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4587,8 +4587,9 @@ transformJsonSerializeExpr(ParseState pstate, JsonSerializeExpr expr)`
`4587`	`4587`	`if (typcategory!=TYPCATEGORY_STRING)`
`4588`	`4588`	`ereport(ERROR,`
`4589`	`4589`	`(errcode(ERRCODE_DATATYPE_MISMATCH),`
`4590`		`-errmsg("cannot use RETURNING type %s in JSON_SERIALIZE",`
`4591`		`-format_type_be(returning->typid)),`
	`4590`	`+errmsg("cannot use RETURNING type %s in %s",`
	`4591`	`+format_type_be(returning->typid),`
	`4592`	`+"JSON_SERIALIZE()"),`
`4592`	`4593`	`errhint("Try returning a string type or bytea")));`
`4593`	`4594`	`}`
`4594`	`4595`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ SELECT pg_typeof(JSON_SERIALIZE(NULL));`
`316`	`316`
`317`	`317`	`-- only string types or bytea allowed`
`318`	`318`	`SELECT JSON_SERIALIZE('{ "a" : 1 } ' RETURNING jsonb);`
`319`		`-ERROR: cannot use RETURNING type jsonb in JSON_SERIALIZE`
	`319`	`+ERROR: cannot use RETURNING type jsonb in JSON_SERIALIZE()`
`320`	`320`	`HINT: Try returning a string type or bytea`
`321`	`321`	`EXPLAIN (VERBOSE, COSTS OFF) SELECT JSON_SERIALIZE('{}');`
`322`	`322`	`QUERY PLAN`

Comments

(0)