NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit831c22b

committed

Add STRICT to some C functions created by the regression tests.

These functions readily crash when passed a NULL input value. The teststhemselves do not pass NULL values to them; but when the regressiondatabase is used as a basis for fuzz testing, they cause a lot of noise.Also, if someone were to leave a regression database lying about in aproduction installation, these would create a minor security hazard.Andreas Seltenreich

1 parentaa06259 commit831c22bCopy full SHA for 831c22b

File tree

2 files changed

+12

-12

lines changed

src/test/regress
- input
  - create_function_2.source
- output
  - create_function_2.source

2 files changed

+12

-12

lines changed

`‎src/test/regress/input/create_function_2.source`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,32 +74,32 @@ CREATE FUNCTION user_relns()`
`74`	`74`	`CREATE FUNCTION pt_in_widget(point, widget)`
`75`	`75`	`RETURNS bool`
`76`	`76`	`AS '@libdir@/regress@DLSUFFIX@'`
`77`		`- LANGUAGE C;`
	`77`	`+ LANGUAGE C STRICT;`
`78`	`78`
`79`	`79`	`CREATE FUNCTION overpaid(emp)`
`80`	`80`	`RETURNS bool`
`81`	`81`	`AS '@libdir@/regress@DLSUFFIX@'`
`82`		`- LANGUAGE C;`
	`82`	`+ LANGUAGE C STRICT;`
`83`	`83`
`84`	`84`	`CREATE FUNCTION boxarea(box)`
`85`	`85`	`RETURNS float8`
`86`	`86`	`AS '@libdir@/regress@DLSUFFIX@'`
`87`		`- LANGUAGE C;`
	`87`	`+ LANGUAGE C STRICT;`
`88`	`88`
`89`	`89`	`CREATE FUNCTION interpt_pp(path, path)`
`90`	`90`	`RETURNS point`
`91`	`91`	`AS '@libdir@/regress@DLSUFFIX@'`
`92`		`- LANGUAGE C;`
	`92`	`+ LANGUAGE C STRICT;`
`93`	`93`
`94`	`94`	`CREATE FUNCTION reverse_name(name)`
`95`	`95`	`RETURNS name`
`96`	`96`	`AS '@libdir@/regress@DLSUFFIX@'`
`97`		`- LANGUAGE C;`
	`97`	`+ LANGUAGE C STRICT;`
`98`	`98`
`99`	`99`	`CREATE FUNCTION oldstyle_length(int4, text)`
`100`	`100`	`RETURNS int4`
`101`	`101`	`AS '@libdir@/regress@DLSUFFIX@'`
`102`		`- LANGUAGE C;`
	`102`	`+ LANGUAGE C; -- intentionally not strict`
`103`	`103`
`104`	`104`	`--`
`105`	`105`	`-- Function dynamic loading`

`‎src/test/regress/output/create_function_2.source`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -58,27 +58,27 @@ CREATE FUNCTION user_relns()`
`58`	`58`	`CREATE FUNCTION pt_in_widget(point, widget)`
`59`	`59`	`RETURNS bool`
`60`	`60`	`AS '@libdir@/regress@DLSUFFIX@'`
`61`		`- LANGUAGE C;`
	`61`	`+ LANGUAGE C STRICT;`
`62`	`62`	`CREATE FUNCTION overpaid(emp)`
`63`	`63`	`RETURNS bool`
`64`	`64`	`AS '@libdir@/regress@DLSUFFIX@'`
`65`		`- LANGUAGE C;`
	`65`	`+ LANGUAGE C STRICT;`
`66`	`66`	`CREATE FUNCTION boxarea(box)`
`67`	`67`	`RETURNS float8`
`68`	`68`	`AS '@libdir@/regress@DLSUFFIX@'`
`69`		`- LANGUAGE C;`
	`69`	`+ LANGUAGE C STRICT;`
`70`	`70`	`CREATE FUNCTION interpt_pp(path, path)`
`71`	`71`	`RETURNS point`
`72`	`72`	`AS '@libdir@/regress@DLSUFFIX@'`
`73`		`- LANGUAGE C;`
	`73`	`+ LANGUAGE C STRICT;`
`74`	`74`	`CREATE FUNCTION reverse_name(name)`
`75`	`75`	`RETURNS name`
`76`	`76`	`AS '@libdir@/regress@DLSUFFIX@'`
`77`		`- LANGUAGE C;`
	`77`	`+ LANGUAGE C STRICT;`
`78`	`78`	`CREATE FUNCTION oldstyle_length(int4, text)`
`79`	`79`	`RETURNS int4`
`80`	`80`	`AS '@libdir@/regress@DLSUFFIX@'`
`81`		`- LANGUAGE C;`
	`81`	`+ LANGUAGE C; -- intentionally not strict`
`82`	`82`	`--`
`83`	`83`	`-- Function dynamic loading`
`84`	`84`	`--`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit831c22b

File tree

2 files changed

2 files changed

`‎src/test/regress/input/create_function_2.source`

`‎src/test/regress/output/create_function_2.source`

0 commit comments