Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit8318f2b

Browse files
vacuumdb: Schema-qualify operator in catalog query's WHERE clause.
Commit1ab67c9, which modified this catalog query so that itdoesn't return temporary relations, forgot to schema-qualify theoperator. A comment earlier in the function implores us to fullyqualify everything in the query: * Since we execute the constructed query with the default search_path * (which could be unsafe), everything in this query MUST be fully * qualified.This commit fixes that. While at it, add a newline for consistencywith surrounding code.Reviewed-by: Noah MischDiscussion:https://postgr.es/m/ZwQJYcuPPUsF0reU%40nathanBackpatch-through: 12
1 parent5d6187d commit8318f2b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

‎src/bin/scripts/vacuumdb.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,8 @@ vacuum_one_database(ConnParams *cparams,
684684
* Exclude temporary tables, beginning the WHERE clause.
685685
*/
686686
appendPQExpBufferStr(&catalog_query,
687-
" WHERE c.relpersistence != "CppAsString2(RELPERSISTENCE_TEMP));
687+
" WHERE c.relpersistence OPERATOR(pg_catalog.!=) "
688+
CppAsString2(RELPERSISTENCE_TEMP)"\n");
688689

689690
/*
690691
* Used to match the tables or schemas listed by the user, for the WHERE

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp