Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit82dd373

Browse files
committed
Avoid lockup of a parallel worker when reporting a long error message.
Because sigsetjmp() will restore the initial state with signals blocked,the code path in bgworker.c for reporting an error and exiting wouldexecute that way. Usually this is fairly harmless; but if a parallelworker had an error message exceeding the shared-memory communicationbuffer size (16K) it would lock up, because it would wait for aresume-sending signal from its parallel leader which it would neverdetect.To fix, just unblock signals at the appropriate point.This can be shown to fail back to 9.6. The lack of parallel queryinfrastructure makes it difficult to provide a simple test case for9.5; but I'm pretty sure the issue exists in some form there as well,so apply the code change there too.Vignesh C, reviewed by Bharath Rupireddy, Robert Haas, and myselfDiscussion:https://postgr.es/m/CALDaNm1d1hHPZUg3xU4XjtWBOLCrA+-2cJcLpw-cePZ=GgDVfA@mail.gmail.com
1 parentfcc4275 commit82dd373

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

‎src/backend/postmaster/bgworker.c

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ StartBackgroundWorker(void)
764764
/*
765765
* If an exception is encountered, processing resumes here.
766766
*
767-
*See notes in postgres.c aboutthedesign of this coding.
767+
*We just need to clean up, reporttheerror, and go away.
768768
*/
769769
if (sigsetjmp(local_sigjmp_buf,1)!=0)
770770
{
@@ -774,7 +774,14 @@ StartBackgroundWorker(void)
774774
/* Prevent interrupts while cleaning up */
775775
HOLD_INTERRUPTS();
776776

777-
/* Report the error to the server log */
777+
/*
778+
* sigsetjmp will have blocked all signals, but we may need to accept
779+
* signals while communicating with our parallel leader. Once we've
780+
* done HOLD_INTERRUPTS() it should be safe to unblock signals.
781+
*/
782+
BackgroundWorkerUnblockSignals();
783+
784+
/* Report the error to the parallel leader and the server log */
778785
EmitErrorReport();
779786

780787
/*

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp