NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit82a0ba7

Amit Kapila

committed

Fix the logical streaming test.

Commit7259736 added the capability to stream changes in ReorderBufferwhich has some tests to test the streaming mode. It is quite possible thatwhile this test is running a parallel transaction could be logged byautovacuum. Such a transaction won't perform any insert/update/delete tonon-catalog tables so will be shown as an empty transaction. Fix it byskipping the empty transactions during this test.Per report by buildfarm.

1 parenta13421c commit82a0ba7Copy full SHA for 82a0ba7

File tree

2 files changed

-4

lines changed

contrib/test_decoding
- expected
  - stream.out
- sql
  - stream.sql

2 files changed

-4

lines changed

`‎contrib/test_decoding/expected/stream.out`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ TRUNCATE table stream_test;`
`26`	`26`	`rollback to s1;`
`27`	`27`	`INSERT INTO stream_test SELECT repeat('a', 10) \|\| g.i FROM generate_series(1, 20) g(i);`
`28`	`28`	`COMMIT;`
`29`		`-SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'stream-changes', '1');`
	`29`	`+SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');`
`30`	`30`	`data`
`31`	`31`	`----------------------------------------------------------`
`32`	`32`	`opening a streamed block for transaction`
`@@ -67,7 +67,7 @@ SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'inc`
`67`	`67`	`(0 rows)`
`68`	`68`
`69`	`69`	`INSERT INTO stream_test SELECT repeat('a', 6000) \|\| g.i FROM generate_series(1, 10) g(i);`
`70`		`-SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'stream-changes', '1');`
	`70`	`+SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');`
`71`	`71`	`data`
`72`	`72`	`------------------------------------------`
`73`	`73`	`opening a streamed block for transaction`

`‎contrib/test_decoding/sql/stream.sql`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,15 +16,15 @@ rollback to s1;`
`16`	`16`	`INSERT INTO stream_test SELECT repeat('a', 10) \|\| g.i FROM generate_series(1, 20) g(i);`
`17`	`17`	`COMMIT;`
`18`	`18`
`19`		`-SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'stream-changes', '1');`
	`19`	`+SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');`
`20`	`20`
`21`	`21`	`-- streaming test for toast changes`
`22`	`22`	`ALTER TABLE stream_test ALTER COLUMN data set storage external;`
`23`	`23`	`-- consume DDL`
`24`	`24`	`SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');`
`25`	`25`
`26`	`26`	`INSERT INTO stream_test SELECT repeat('a', 6000) \|\| g.i FROM generate_series(1, 10) g(i);`
`27`		`-SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'stream-changes', '1');`
	`27`	`+SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL,NULL, 'include-xids', '0', 'skip-empty-xacts', '1', 'stream-changes', '1');`
`28`	`28`
`29`	`29`	`DROP TABLE stream_test;`
`30`	`30`	`SELECT pg_drop_replication_slot('regression_slot');`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit82a0ba7

File tree

2 files changed

2 files changed

`‎contrib/test_decoding/expected/stream.out`

`‎contrib/test_decoding/sql/stream.sql`

0 commit comments