NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8279f68

committed

Ignore more environment variables in TAP tests

Various environment variables were not getting reset in the TAP tests,which would cause failures depending on the tests or the environmentvariables involved. For example, PGSSL{MAX,MIN}PROTOCOLVERSION couldcause failures in the SSL tests. Even worse, a junk value ofPGCLIENTENCODING makes a server startup fail. The list of variablesreset is adjusted in each stable branch depending on what is supported.While on it, simplify a bit the code per a suggestion from AndrewDunstan, using a list of variables instead of doing single deletions.Reviewed-by: Andrew Dunstan, Daniel GustafssonDiscussion:https://postgr.es/m/YLbjjRpucIeZ78VQ@paquier.xyzBackpatch-through: 9.6

1 parent2955c2b commit8279f68Copy full SHA for 8279f68

File tree

1 file changed

+32

-11

lines changed

src/test/perl
- TestLib.pm

1 file changed

+32

-11

lines changed

`‎src/test/perl/TestLib.pm`

Lines changed: 32 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,17 +104,38 @@ BEGIN`
`104`	`104`	`delete$ENV{LC_ALL};`
`105`	`105`	`$ENV{LC_MESSAGES} ='C';`
`106`	`106`
`107`		`-delete$ENV{PGCONNECT_TIMEOUT};`
`108`		`-delete$ENV{PGDATA};`
`109`		`-delete$ENV{PGDATABASE};`
`110`		`-delete$ENV{PGHOSTADDR};`
`111`		`-delete$ENV{PGREQUIRESSL};`
`112`		`-delete$ENV{PGSERVICE};`
`113`		`-delete$ENV{PGSSLMODE};`
`114`		`-delete$ENV{PGUSER};`
`115`		`-delete$ENV{PGPORT};`
`116`		`-delete$ENV{PGHOST};`
`117`		`-delete$ENV{PG_COLOR};`
	`107`	`+my@envkeys =qw (`
	`108`	`+ PGCHANNELBINDING`
	`109`	`+ PGCLIENTENCODING`
	`110`	`+ PGCONNECT_TIMEOUT`
	`111`	`+ PGDATA`
	`112`	`+ PGDATABASE`
	`113`	`+ PGGSSENCMODE`
	`114`	`+ PGGSSLIB`
	`115`	`+ PGHOSTADDR`
	`116`	`+ PGKRBSRVNAME`
	`117`	`+ PGPASSFILE`
	`118`	`+ PGPASSWORD`
	`119`	`+ PGREQUIREPEER`
	`120`	`+ PGREQUIRESSL`
	`121`	`+ PGSERVICE`
	`122`	`+ PGSERVICEFILE`
	`123`	`+ PGSSLCERT`
	`124`	`+ PGSSLCRL`
	`125`	`+ PGSSLCRLDIR`
	`126`	`+ PGSSLKEY`
	`127`	`+ PGSSLMAXPROTOCOLVERSION`
	`128`	`+ PGSSLMINPROTOCOLVERSION`
	`129`	`+ PGSSLMODE`
	`130`	`+ PGSSLROOTCERT`
	`131`	`+ PGSSLSNI`
	`132`	`+ PGTARGETSESSIONATTRS`
	`133`	`+ PGUSER`
	`134`	`+ PGPORT`
	`135`	`+ PGHOST`
	`136`	`+ PG_COLOR`
	`137`	`+);`
	`138`	`+delete@ENV{@envkeys};`
`118`	`139`
`119`	`140`	`$ENV{PGAPPNAME} = basename($0);`
`120`	`141`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8279f68

File tree

1 file changed

1 file changed

`‎src/test/perl/TestLib.pm`

0 commit comments