forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit823e739
committed
Test GROUP BY matching of join columns that are type-coerced by USING.
If we have, say, an int column that is left-joined to a bigint columnwith USING, the merged column is the int column promoted to bigint.GROUP BY's tests for whether grouping on the merged column allows areference to the underlying column, or vice versa, should know aboutthat relationship --- and they do. But I nearly broke this case withan ill-advised optimization, so the lack of any test coverage for itseems like a bad idea.1 parentc5f3b53 commit823e739
2 files changed
+41
-0
lines changedLines changed: 26 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1194 | 1194 |
| |
1195 | 1195 |
| |
1196 | 1196 |
| |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
| 1215 | + | |
| 1216 | + | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
| 1220 | + | |
| 1221 | + | |
| 1222 | + | |
1197 | 1223 |
| |
1198 | 1224 |
| |
1199 | 1225 |
| |
|
Lines changed: 15 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
432 | 432 |
| |
433 | 433 |
| |
434 | 434 |
| |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
435 | 450 |
| |
436 | 451 |
| |
437 | 452 |
| |
|
0 commit comments
Comments
(0)