NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit81a23dd

committed

Avoid unnecessary table open/close in TRUNCATE command.

ExecuteTruncate() filters out the duplicate tables specifiedin the TRUNCATE command, for example in the case where "TRUNCATE foo, foo"is executed. Such duplicate tables obviously don't need to be openedand closed because they are skipped. But previously it always openedthe tables before checking whether they were duplicated ones or not,and then closed them if they were. That is, the duplicated tables wereopened and closed unnecessarily.This commit changes ExecuteTruncate() so that it opens the tableafter it confirms that table is not duplicated one, which leads toavoid unnecessary table open/close.Do not back-patch because such unnecessary table open/close is nota bug though it exists in older versions.Author: Bharath RupireddyReviewed-by: Amul Sul, Fujii MasaoDiscussion:https://postgr.es/m/CALj2ACUdBO_sXJTa08OZ0YT0qk7F_gAmRa9hT4dxRcgPS4nsZA@mail.gmail.com

1 parent08aa89b commit81a23ddCopy full SHA for 81a23dd

File tree

1 file changed

-6

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-6

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1639,15 +1639,12 @@ ExecuteTruncate(TruncateStmt *stmt)`
`1639`	`1639`	`0, RangeVarCallbackForTruncate,`
`1640`	`1640`	`NULL);`
`1641`	`1641`
`1642`		`-/* open the relation, we already hold a lock on it */`
`1643`		`-rel = table_open(myrelid, NoLock);`
`1644`		`-`
`1645`	`1642`	`/* don't throw error for "TRUNCATE foo, foo" */`
`1646`	`1643`	`if (list_member_oid(relids, myrelid))`
`1647`		`-{`
`1648`		`-table_close(rel, lockmode);`
`1649`	`1644`	`continue;`
`1650`		`-}`
	`1645`	`+`
	`1646`	`+/* open the relation, we already hold a lock on it */`
	`1647`	`+rel = table_open(myrelid, NoLock);`
`1651`	`1648`
`1652`	`1649`	`/*`
`1653`	`1650`	`* RangeVarGetRelidExtended() has done most checks with its callback,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit81a23dd

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments