NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8148e71

committed

Fix lc_collate_is_c() when LC_COLLATE != LC_CTYPE.

An unfortunate typo in commit2d819a0 can cause wrong results whenthe default collation provider is libc, LC_CTYPE=C, and LC_COLLATE isa real locale. Users with this combination of settings must REINDEXall affected indexes.The same typo can also cause performance degradation when LC_COLLATE=Cand LC_CTYPE is a real locale.Problem does not exist in master (due to refactoring), so fix only inversion 17.Reported-by: Drew CallahanDiscussion:https://postgr.es/m/d5081a7f4f6d425c28dd69d1e09b2e78f149e726.camel@j-davis.com

1 parentb7467ab commit8148e71Copy full SHA for 8148e71

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- pg_locale.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/pg_locale.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1370,9 +1370,9 @@ lc_collate_is_c(Oid collation)`
`1370`	`1370`	`}`
`1371`	`1371`	`elseif (default_locale.provider==COLLPROVIDER_LIBC)`
`1372`	`1372`	`{`
`1373`		`-localeptr=setlocale(LC_CTYPE,NULL);`
	`1373`	`+localeptr=setlocale(LC_COLLATE,NULL);`
`1374`	`1374`	`if (!localeptr)`
`1375`		`-elog(ERROR,"invalidLC_CTYPE setting");`
	`1375`	`+elog(ERROR,"invalidLC_COLLATE setting");`
`1376`	`1376`	`}`
`1377`	`1377`	`else`
`1378`	`1378`	`elog(ERROR,"unexpected collation provider '%c'",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8148e71

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/pg_locale.c‎`

0 commit comments