NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8143a56

committed

Fix minor bug in XLogFileRead() that accidentally worked.

Cascading replication copied the incoming file into pg_xlog butdidn't set path correctly, so the first attempt to open file failedcausing it to loop around and look for file in pg_xlog. So theearlier coding worked, but accidentally rather than by design.Spotted by Fujii Masao, fix by Fujii Masao and Simon Riggs

1 parent21786db commit8143a56Copy full SHA for 8143a56

File tree

1 file changed

-0

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-0

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2805,6 +2805,11 @@ XLogFileRead(XLogSegNo segno, int emode, TimeLineID tli,`
`2805`	`2805`	`errmsg("could not rename file \"%s\" to \"%s\": %m",`
`2806`	`2806`	`path,xlogfpath)));`
`2807`	`2807`
	`2808`	`+/*`
	`2809`	`+ * Set path to point at the new file in pg_xlog.`
	`2810`	`+ */`
	`2811`	`+strncpy(path,xlogfpath,MAXPGPATH);`
	`2812`	`+`
`2808`	`2813`	`/*`
`2809`	`2814`	`* If the existing segment was replaced, since walsenders might have`
`2810`	`2815`	`* it open, request them to reload a currently-open segment.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8143a56

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments