Commit813895e

committed

Don't pass oidvector by value.

Since the structure ends with a flexible array, doing so truncates anyvector having more than one element. New in 9.3, so no back-patch.

1 parentfb435f4 commit813895eCopy full SHA for 813895e

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ AlterObjectRename_internal(Relation rel, Oid objectId, const char *new_name)`
`231`	`231`	`Form_pg_procproc= (Form_pg_proc)GETSTRUCT(oldtup);`
`232`	`232`
`233`	`233`	`IsThereFunctionInNamespace(new_name,proc->pronargs,`
`234`		`-proc->proargtypes,proc->pronamespace);`
	`234`	`+&proc->proargtypes,proc->pronamespace);`
`235`	`235`	`}`
`236`	`236`	`elseif (classId==CollationRelationId)`
`237`	`237`	`{`
`@@ -611,7 +611,7 @@ AlterObjectNamespace_internal(Relation rel, Oid objid, Oid nspOid)`
`611`	`611`	`Form_pg_procproc= (Form_pg_proc)GETSTRUCT(tup);`
`612`	`612`
`613`	`613`	`IsThereFunctionInNamespace(NameStr(proc->proname),proc->pronargs,`
`614`		`-proc->proargtypes,nspOid);`
	`614`	`+&proc->proargtypes,nspOid);`
`615`	`615`	`}`
`616`	`616`	`elseif (classId==CollationRelationId)`
`617`	`617`	`{`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1626,18 +1626,18 @@ DropCastById(Oid castOid)`
`1626`	`1626`	`*/`
`1627`	`1627`	`void`
`1628`	`1628`	`IsThereFunctionInNamespace(constchar*proname,intpronargs,`
`1629`		`-oidvectorproargtypes,OidnspOid)`
	`1629`	`+oidvector*proargtypes,OidnspOid)`
`1630`	`1630`	`{`
`1631`	`1631`	`/* check for duplicate name (more friendly than unique-index failure) */`
`1632`	`1632`	`if (SearchSysCacheExists3(PROCNAMEARGSNSP,`
`1633`	`1633`	`CStringGetDatum(proname),`
`1634`		`-PointerGetDatum(&proargtypes),`
	`1634`	`+PointerGetDatum(proargtypes),`
`1635`	`1635`	`ObjectIdGetDatum(nspOid)))`
`1636`	`1636`	`ereport(ERROR,`
`1637`	`1637`	`(errcode(ERRCODE_DUPLICATE_FUNCTION),`
`1638`	`1638`	`errmsg("function %s already exists in schema \"%s\"",`
`1639`	`1639`	`funcname_signature_string(proname,pronargs,`
`1640`		`-NIL,proargtypes.values),`
	`1640`	`+NIL,proargtypes->values),`
`1641`	`1641`	`get_namespace_name(nspOid))));`
`1642`	`1642`	`}`
`1643`	`1643`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ extern OidAlterFunction(AlterFunctionStmt *stmt);`
`50`	`50`	`externOidCreateCast(CreateCastStmt*stmt);`
`51`	`51`	`externvoidDropCastById(OidcastOid);`
`52`	`52`	`externvoidIsThereFunctionInNamespace(constchar*proname,intpronargs,`
`53`		`-oidvectorproargtypes,OidnspOid);`
	`53`	`+oidvector*proargtypes,OidnspOid);`
`54`	`54`	`externvoidExecuteDoStmt(DoStmt*stmt);`
`55`	`55`	`externOidget_cast_oid(Oidsourcetypeid,Oidtargettypeid,boolmissing_ok);`
`56`	`56`

Comments

(0)