NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit811969b

committed

Allocate enough shared string memory for stats of auxiliary processes.

This fixes a bug whereby the st_appname, st_clienthostname, andst_activity_raw fields for auxiliary processes point beyond the end oftheir respective shared memory segments. As a result, the application_nameof a backend might show up as the client hostname of an auxiliary process.Backpatch to v10, where this bug was introduced, when the auxiliaryprocesses were added to the array.Author: Edmund HornerReviewed-by: Michael PaquierDiscussion:https://www.postgresql.org/message-id/CAMyN-kA7aOJzBmrYFdXcc7Z0NmW%2B5jBaf_m%3D_-77uRNyKC9r%3DA%40mail.gmail.com

1 parenta820b4c commit811969bCopy full SHA for 811969b

File tree

1 file changed

-2

lines changed

src/backend/postmaster
- pgstat.c

1 file changed

-2

lines changed

`‎src/backend/postmaster/pgstat.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2650,7 +2650,7 @@ CreateSharedBackendStatus(void)`
`2650`	`2650`	`}`
`2651`	`2651`
`2652`	`2652`	`/* Create or attach to the shared appname buffer */`
`2653`		`-size=mul_size(NAMEDATALEN,MaxBackends);`
	`2653`	`+size=mul_size(NAMEDATALEN,NumBackendStatSlots);`
`2654`	`2654`	`BackendAppnameBuffer= (char*)`
`2655`	`2655`	`ShmemInitStruct("Backend Application Name Buffer",size,&found);`
`2656`	`2656`
`@@ -2668,7 +2668,7 @@ CreateSharedBackendStatus(void)`
`2668`	`2668`	`}`
`2669`	`2669`
`2670`	`2670`	`/* Create or attach to the shared client hostname buffer */`
`2671`		`-size=mul_size(NAMEDATALEN,MaxBackends);`
	`2671`	`+size=mul_size(NAMEDATALEN,NumBackendStatSlots);`
`2672`	`2672`	`BackendClientHostnameBuffer= (char*)`
`2673`	`2673`	`ShmemInitStruct("Backend Client Host Name Buffer",size,&found);`
`2674`	`2674`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit811969b

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/pgstat.c`

0 commit comments