Commit8112bcf

committed

Fix overly generic name in with.sql test.

Avoid the name "test". In the 10 branch, this could clash withalter_table.sql, as seen in the build farm. That other instance wasalready renamed in later branches by commit2cf8c7a, but it's good tofuture-proof the name here too.Back-patch to 10.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/CA%2BhUKGJf4RAXUyAYVUcQawcptX%3DnhEco3SYpuPK5cCbA-F1eLA%40mail.gmail.com

1 parent1fb17b1 commit8112bcfCopy full SHA for 8112bcf

File tree

+13

-13

lines changed

+13

-13

lines changed

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -3149,19 +3149,19 @@ with ordinality as (select 1 as x) select * from ordinality;`
`3149`	`3149`	`(1 row)`
`3150`	`3150`
`3151`	`3151`	`-- check sane response to attempt to modify CTE relation`
`3152`		`-WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`3153`		`-ERROR: relation "test" does not exist`
`3154`		`-LINE 1: WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`3155`		`- ^`
	`3152`	`+WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (1);`
	`3153`	`+ERROR: relation "with_test" does not exist`
	`3154`	`+LINE 1: WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (...`
	`3155`	`+^`
`3156`	`3156`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`3157`	`3157`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`3158`	`3158`	`-- statements)`
`3159`		`-create temp tabletest (i int);`
`3160`		`-withtest as (select 42) insert intotest select * fromtest;`
`3161`		`-select * fromtest;`
	`3159`	`+create temp tablewith_test (i int);`
	`3160`	`+withwith_test as (select 42) insert intowith_test select * fromwith_test;`
	`3161`	`+select * fromwith_test;`
`3162`	`3162`	`i`
`3163`	`3163`	`----`
`3164`	`3164`	`42`
`3165`	`3165`	`(1 row)`
`3166`	`3166`
`3167`		`-drop tabletest;`
	`3167`	`+drop tablewith_test;`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1459,12 +1459,12 @@ create table foo (with ordinality); -- fail, WITH is a reserved word`
`1459`	`1459`	`with ordinalityas (select1as x)select*from ordinality;`
`1460`	`1460`
`1461`	`1461`	`-- check sane response to attempt to modify CTE relation`
`1462`		`-WITHtestAS (SELECT42)INSERT INTOtestVALUES (1);`
	`1462`	`+WITHwith_testAS (SELECT42)INSERT INTOwith_testVALUES (1);`
`1463`	`1463`
`1464`	`1464`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`1465`	`1465`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`1466`	`1466`	`-- statements)`
`1467`		`-create temp tabletest (iint);`
`1468`		`-withtestas (select42)insert intotestselect*fromtest;`
`1469`		`-select*fromtest;`
`1470`		`-droptabletest;`
	`1467`	`+create temp tablewith_test (iint);`
	`1468`	`+withwith_testas (select42)insert intowith_testselect*fromwith_test;`
	`1469`	`+select*fromwith_test;`
	`1470`	`+droptablewith_test;`

Comments

(0)