NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit806fc52

committed

Fix unportable usage of <ctype.h> functions.

isdigit(), isspace(), etc are likely to give surprising results if passed asigned char. We should always cast the argument to unsigned char to avoidthat. Error in commit63d6b97, found by buildfarm member gaur.Back-patch to 9.3, like that commit.

1 parentf3eff7b commit806fc52Copy full SHA for 806fc52

File tree

1 file changed

-1

lines changed

src/interfaces/ecpg/ecpglib
- data.c

1 file changed

-1

lines changed

`‎src/interfaces/ecpg/ecpglib/data.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ garbage_left(enum ARRAY_TYPE isarray, char **scan_length, enum COMPAT_MODE compa`
`59`	`59`	`/* skip invalid characters */`
`60`	`60`	`do {`
`61`	`61`	`(*scan_length)++;`
`62`		`-}while (isdigit(**scan_length));`
	`62`	`+}while (isdigit((unsignedchar)**scan_length));`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`if (scan_length!=' '&&scan_length!='\0')`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit806fc52

File tree

1 file changed

1 file changed

`‎src/interfaces/ecpg/ecpglib/data.c`

0 commit comments