Commit80276c0

authored and

committed

Fix _bt_allequalimage() call within critical section.

_bt_allequalimage() does complicated things, so it's not OK to call itin a critical section. Per buildfarm failure on 'prion', which uses-DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE options.Discussion:https://www.postgresql.org/message-id/6e5bbc08-cdfc-b2b3-9e23-1a914b9850a9@iki.fiBackpatch-through: 16, like commitccadf73 that introduced this

1 parente55ef2f commit80276c0Copy full SHA for 80276c0

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,7 @@ bthandler(PG_FUNCTION_ARGS)`
`151`	`151`	`void`
`152`	`152`	`btbuildempty(Relationindex)`
`153`	`153`	`{`
	`154`	`+boolallequalimage=_bt_allequalimage(index, false);`
`154`	`155`	`Buffermetabuf;`
`155`	`156`	`Pagemetapage;`
`156`	`157`
`@@ -169,7 +170,7 @@ btbuildempty(Relation index)`
`169`	`170`	`START_CRIT_SECTION();`
`170`	`171`
`171`	`172`	`metapage=BufferGetPage(metabuf);`
`172`		`-_bt_initmetapage(metapage,P_NONE,0,_bt_allequalimage(index, false));`
	`173`	`+_bt_initmetapage(metapage,P_NONE,0,allequalimage);`
`173`	`174`	`MarkBufferDirty(metabuf);`
`174`	`175`	`log_newpage_buffer(metabuf, true);`
`175`	`176`

Comments

(0)