Commit8015ba0

committed

Prevent relname unallocated string length from being copied into database.

1 parent105889e commit8015ba0Copy full SHA for 8015ba0

File tree

-4

lines changed

-4

lines changed

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/Attic/creatinh.c,v 1.6 1997/04/0203:57:06 vadim Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/creatinh.c,v 1.7 1997/08/0219:09:33 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -46,7 +46,7 @@ static void StoreCatalogInheritance(Oid relationId, List *supers);`
`46`	`46`	`void`
`47`	`47`	`DefineRelation(CreateStmt*stmt)`
`48`	`48`	`{`
`49`		`-char*relname=stmt->relname;`
	`49`	`+char*relname=palloc(NAMEDATALEN+1);`
`50`	`50`	`List*schema=stmt->tableElts;`
`51`	`51`	`intnumberOfAttributes;`
`52`	`52`	`OidrelationId;`
`@@ -58,9 +58,10 @@ DefineRelation(CreateStmt *stmt)`
`58`	`58`
`59`	`59`	`chartypename=NULL;/ the typename of this relation. not useod for now */`
`60`	`60`
`61`		`-if (strlen(relname)>NAMEDATALEN)`
`62`		`-elog(WARN,"the relation name %s is > %d characters long",relname,`
	`61`	`+if (strlen(stmt->relname)>NAMEDATALEN)`
	`62`	`+elog(WARN,"the relation name %s is > %d characters long",stmt->relname,`
`63`	`63`	`NAMEDATALEN);`
	`64`	`+strncpy(relname,stmt->relname,NAMEDATALEN+1);/* make full length for copy */`
`64`	`65`
`65`	`66`	`/* ----------------`
`66`	`67`	`* Handle parameters`

Comments

(0)