Commit801386a

committed

Clarify old comment about qual_is_pushdown_safe's handling of subplans.

This comment glossed over the difference between initplans and subplans,but they are indeed different for our purposes here.

1 parent3848d21 commit801386aCopy full SHA for 801386a

File tree

-3

lines changed

-3

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2840,9 +2840,11 @@ targetIsInAllPartitionLists(TargetEntry tle, Query query)`
`2840`	`2840`	`*`
`2841`	`2841`	`* Conditions checked here:`
`2842`	`2842`	`*`
`2843`		`- * 1. The qual must not contain any subselects (mainly because I'm not sure`
`2844`		`- * it will work correctly: sublinks will already have been transformed into`
`2845`		`- * subplans in the qual, but not in the subquery).`
	`2843`	`+ * 1. The qual must not contain any SubPlans (mainly because I'm not sure`
	`2844`	`+ * it will work correctly: SubLinks will already have been transformed into`
	`2845`	`+ * SubPlans in the qual, but not in the subquery). Note that SubLinks that`
	`2846`	`+ * transform to initplans are safe, and will be accepted here because what`
	`2847`	`+ * we'll see in the qual is just a Param referencing the initplan output.`
`2846`	`2848`	`*`
`2847`	`2849`	`* 2. If unsafeVolatile is set, the qual must not contain any volatile`
`2848`	`2850`	`* functions.`

Comments

(0)