NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit8001cb7

committed

Fix heap_page_prune() parameter order confusion introduced indc7420c.

Both luckily and unluckily the passed values meant the same for alltypes. Luckily because that meant my confusion caused no harm,unluckily because otherwise the compiler might have warned...In passing, synchronize parameter names between definition anddeclaration.Reported-By: Peter Geoghegan <pg@bowt.ie>Author: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/CAH2-Wz=L=nBoepQdH9b5Qd0nMvepFT2CnT6sjWvvpOXa=K8HVQ@mail.gmail.com

1 parenta975ff4 commit8001cb7Copy full SHA for 8001cb7

File tree

2 files changed

-4

lines changed

src
- backend/access/heap
  - vacuumlazy.c
- include/access
  - heapam.h

2 files changed

-4

lines changed

`‎src/backend/access/heap/vacuumlazy.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1237,8 +1237,8 @@ lazy_scan_heap(Relation onerel, VacuumParams params, LVRelStats vacrelstats,`
`1237`	`1237`	`* We count tuples removed by the pruning step as removed by VACUUM`
`1238`	`1238`	`* (existing LP_DEAD line pointers don't count).`
`1239`	`1239`	`*/`
`1240`		`-tups_vacuumed+=heap_page_prune(onerel,buf,vistest, false,`
`1241`		`-InvalidTransactionId,0,`
	`1240`	`+tups_vacuumed+=heap_page_prune(onerel,buf,vistest,`
	`1241`	`+InvalidTransactionId,0, false,`
`1242`	`1242`	`&vacrelstats->latestRemovedXid,`
`1243`	`1243`	`&vacrelstats->offnum);`
`1244`	`1244`

`‎src/include/access/heapam.h`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,8 @@ struct GlobalVisState;`
`174`	`174`	`externvoidheap_page_prune_opt(Relationrelation,Bufferbuffer);`
`175`	`175`	`externintheap_page_prune(Relationrelation,Bufferbuffer,`
`176`	`176`	`structGlobalVisState*vistest,`
`177`		`-TransactionIdlimited_oldest_xmin,`
`178`		`-TimestampTzlimited_oldest_ts,`
	`177`	`+TransactionIdold_snap_xmin,`
	`178`	`+TimestampTzold_snap_ts_ts,`
`179`	`179`	`boolreport_stats,TransactionId*latestRemovedXid,`
`180`	`180`	`OffsetNumber*off_loc);`
`181`	`181`	`externvoidheap_page_prune_execute(Bufferbuffer,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8001cb7

File tree

2 files changed

2 files changed

`‎src/backend/access/heap/vacuumlazy.c`

`‎src/include/access/heapam.h`

0 commit comments