Commit7feaccc

committed

Allow setting effective_io_concurrency even on unsupported systems

This matches the behavior of other parameters that are unsupported onsome systems (e.g., ssl).Also document the default value.

1 parentb87671f commit7feacccCopy full SHA for 7feaccc

File tree

+10

-4

lines changed

+10

-4

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1892,6 +1892,10 @@ include_dir 'conf.d'`
`1892`	`1892`	`in an error. On some operating systems (e.g., Solaris), the function`
`1893`	`1893`	`is present but does not actually do anything.`
`1894`	`1894`	`</para>`
	`1895`	`+`
	`1896`	`+ <para>`
	`1897`	`+ The default is 1 on supported systems, otherwise 0.`
	`1898`	`+ </para>`
`1895`	`1899`	`</listitem>`
`1896`	`1900`	`</varlistentry>`
`1897`	`1901`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2258,11 +2258,7 @@ static struct config_int ConfigureNamesInt[] =`
`2258`	`2258`
`2259`	`2259`	`{`
`2260`	`2260`	`{"effective_io_concurrency",`
`2261`		`-#ifdefUSE_PREFETCH`
`2262`	`2261`	`PGC_USERSET,`
`2263`		`-#else`
`2264`		`-PGC_INTERNAL,`
`2265`		`-#endif`
`2266`	`2262`	`RESOURCES_ASYNCHRONOUS,`
`2267`	`2263`	`gettext_noop("Number of simultaneous requests that can be handled efficiently by the disk subsystem."),`
`2268`	`2264`	`gettext_noop("For RAID arrays, this should be approximately the number of drive spindles in the array.")`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1288,6 +1288,12 @@ setup_config(void)`
`1288`	`1288`	`conflines=replace_token(conflines,"#dynamic_shared_memory_type = posix",`
`1289`	`1289`	`repltok);`
`1290`	`1290`
	`1291`	`+#if !USE_PREFETCH`
	`1292`	`+conflines=replace_token(conflines,`
	`1293`	`+"#effective_io_concurrency = 1",`
	`1294`	`+"#effective_io_concurrency = 0");`
	`1295`	`+#endif`
	`1296`	`+`
`1291`	`1297`	`snprintf(path,sizeof(path),"%s/postgresql.conf",pg_data);`
`1292`	`1298`
`1293`	`1299`	`writefile(path,conflines);`

Comments

(0)