NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7fdbdf2

committed

pgstat: fix stats.spec instability on slow machines.

On slow machines the modified test could end up switching the order in whichtransactional stats are reported in one session and non-transactional stats inanother session. As stats handling of truncate is implemented as settinglive/dead rows 0, the order in which a truncate's stats changes are applied,relative to normal stats updates, matters. The handling of stats for truncatehasn't changed due to shared memory stats, this is longstanding behavior.We might want to improve truncate's stats handling in the future, but for nowjust change the order of forced flushed to make the test stable.Reported-By: Christoph Berg <myon@debian.org>Discussion:https://postgr.es/m/YoZf7U/WmfmFYFEx@msg.df7cb.de

1 parentc7461fc commit7fdbdf2Copy full SHA for 7fdbdf2

File tree

3 files changed

-6

lines changed

src/test/isolation
- expected
  - stats.out
  - stats_1.out
- specs
  - stats.spec

3 files changed

-6

lines changed

`‎src/test/isolation/expected/stats.out`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2812,7 +2812,7 @@ seq_scan\|seq_tup_read\|n_tup_ins\|n_tup_upd\|n_tup_del\|n_live_tup\|n_dead_tup\|vacuum`
`2812`	`2812`	`(1 row)`
`2813`	`2813`
`2814`	`2814`
`2815`		`-starting permutation: s1_table_insert s1_begin s1_table_update_k1 s1_table_update_k1 s1_table_truncate s1_table_insert_k1 s1_table_update_k1 s1_prepare_as2_commit_prepared_as1_ff s2_ff s1_table_stats`
	`2815`	`+starting permutation: s1_table_insert s1_begin s1_table_update_k1 s1_table_update_k1 s1_table_truncate s1_table_insert_k1 s1_table_update_k1 s1_prepare_a s1_ff s2_commit_prepared_a s2_ff s1_table_stats`
`2816`	`2816`	`pg_stat_force_next_flush`
`2817`	`2817`	`------------------------`
`2818`	`2818`
`@@ -2826,13 +2826,13 @@ step s1_table_truncate: TRUNCATE test_stat_tab;`
`2826`	`2826`	`step s1_table_insert_k1: INSERT INTO test_stat_tab(key, value) VALUES('k1', 1);`
`2827`	`2827`	`step s1_table_update_k1: UPDATE test_stat_tab SET value = value + 1 WHERE key = 'k1';`
`2828`	`2828`	`step s1_prepare_a: PREPARE TRANSACTION 'a';`
`2829`		`-step s2_commit_prepared_a: COMMIT PREPARED 'a';`
`2830`	`2829`	`step s1_ff: SELECT pg_stat_force_next_flush();`
`2831`	`2830`	`pg_stat_force_next_flush`
`2832`	`2831`	`------------------------`
`2833`	`2832`
`2834`	`2833`	`(1 row)`
`2835`	`2834`
	`2835`	`+step s2_commit_prepared_a: COMMIT PREPARED 'a';`
`2836`	`2836`	`step s2_ff: SELECT pg_stat_force_next_flush();`
`2837`	`2837`	`pg_stat_force_next_flush`
`2838`	`2838`	`------------------------`

`‎src/test/isolation/expected/stats_1.out`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2826,7 +2826,7 @@ seq_scan\|seq_tup_read\|n_tup_ins\|n_tup_upd\|n_tup_del\|n_live_tup\|n_dead_tup\|vacuum`
`2826`	`2826`	`(1 row)`
`2827`	`2827`
`2828`	`2828`
`2829`		`-starting permutation: s1_table_insert s1_begin s1_table_update_k1 s1_table_update_k1 s1_table_truncate s1_table_insert_k1 s1_table_update_k1 s1_prepare_as2_commit_prepared_as1_ff s2_ff s1_table_stats`
	`2829`	`+starting permutation: s1_table_insert s1_begin s1_table_update_k1 s1_table_update_k1 s1_table_truncate s1_table_insert_k1 s1_table_update_k1 s1_prepare_a s1_ff s2_commit_prepared_a s2_ff s1_table_stats`
`2830`	`2830`	`pg_stat_force_next_flush`
`2831`	`2831`	`------------------------`
`2832`	`2832`
`@@ -2841,14 +2841,14 @@ step s1_table_insert_k1: INSERT INTO test_stat_tab(key, value) VALUES('k1', 1);`
`2841`	`2841`	`step s1_table_update_k1: UPDATE test_stat_tab SET value = value + 1 WHERE key = 'k1';`
`2842`	`2842`	`step s1_prepare_a: PREPARE TRANSACTION 'a';`
`2843`	`2843`	`ERROR: prepared transactions are disabled`
`2844`		`-step s2_commit_prepared_a: COMMIT PREPARED 'a';`
`2845`		`-ERROR: prepared transaction with identifier "a" does not exist`
`2846`	`2844`	`step s1_ff: SELECT pg_stat_force_next_flush();`
`2847`	`2845`	`pg_stat_force_next_flush`
`2848`	`2846`	`------------------------`
`2849`	`2847`
`2850`	`2848`	`(1 row)`
`2851`	`2849`
	`2850`	`+step s2_commit_prepared_a: COMMIT PREPARED 'a';`
	`2851`	`+ERROR: prepared transaction with identifier "a" does not exist`
`2852`	`2852`	`step s2_ff: SELECT pg_stat_force_next_flush();`
`2853`	`2853`	`pg_stat_force_next_flush`
`2854`	`2854`	`------------------------`

`‎src/test/isolation/specs/stats.spec`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -562,8 +562,9 @@ permutation`
`562`	`562`	`s1_table_insert_k1# should be counted`
`563`	`563`	`s1_table_update_k1# dito`
`564`	`564`	`s1_prepare_a`
	`565`	`+s1_ff# flush out non-transactional stats, might happen anyway`
`565`	`566`	`s2_commit_prepared_a`
`566`		`-s1_ffs2_ff`
	`567`	`+s2_ff`
`567`	`568`	`s1_table_stats`
`568`	`569`
`569`	`570`	`# S1 prepares, S1 aborts prepared`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7fdbdf2

File tree

3 files changed

3 files changed

`‎src/test/isolation/expected/stats.out`

`‎src/test/isolation/expected/stats_1.out`

`‎src/test/isolation/specs/stats.spec`

0 commit comments