Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7f97b47

Browse files
committed
Fix some comments related to library unloading
Library unloading has never been supported with its code removed inab02d70, and there were some comments still mentioning that it wasa possible operation.ChangAo has noticed the incorrect references in dfmgr.c, while I havenoticed the other ones while scanning the rest of the tree for similarmistakes.Author: ChangAo Chen, Michael PaquierReviewed-by: Tom LaneDiscussion:https://postgr.es/m/tencent_1D09840A1632D406A610C8C4E2491D74DB0A@qq.com
1 parent578a7fe commit7f97b47

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

‎contrib/auto_explain/auto_explain.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ static bool current_query_sampled = false;
7070
(nesting_level == 0 || auto_explain_log_nested_statements) && \
7171
current_query_sampled)
7272

73-
/* Saved hook valuesin case of unload*/
73+
/* Saved hook values */
7474
staticExecutorStart_hook_typeprev_ExecutorStart=NULL;
7575
staticExecutorRun_hook_typeprev_ExecutorRun=NULL;
7676
staticExecutorFinish_hook_typeprev_ExecutorFinish=NULL;

‎contrib/passwordcheck/passwordcheck.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
PG_MODULE_MAGIC;
2828

29-
/* Saved hook valuein case of unload*/
29+
/* Saved hook value */
3030
staticcheck_password_hook_typeprev_check_password_hook=NULL;
3131

3232
/* passwords shorter than this will be rejected */

‎contrib/pg_stat_statements/pg_stat_statements.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ typedef struct pgssSharedState
256256
/* Current nesting depth of planner/ExecutorRun/ProcessUtility calls */
257257
staticintnesting_level=0;
258258

259-
/* Saved hook valuesin case of unload*/
259+
/* Saved hook values */
260260
staticshmem_request_hook_typeprev_shmem_request_hook=NULL;
261261
staticshmem_startup_hook_typeprev_shmem_startup_hook=NULL;
262262
staticpost_parse_analyze_hook_typeprev_post_parse_analyze_hook=NULL;

‎contrib/sepgsql/hooks.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ sepgsql_utility_command(PlannedStmt *pstmt,
394394
}
395395

396396
/*
397-
* Module load/unload callback
397+
* Module load callback
398398
*/
399399
void
400400
_PG_init(void)

‎src/backend/utils/fmgr/dfmgr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ load_external_function(const char *filename, const char *funcname,
125125
/*
126126
* This function loads a shlib file without looking up any particular
127127
* function in it. If the same shlib has previously been loaded,
128-
*unload and reload it.
128+
*we do not load it again.
129129
*
130130
* When 'restricted' is true, only libraries in the presumed-secure
131131
* directory $libdir/plugins may be referenced.
@@ -142,7 +142,7 @@ load_file(const char *filename, bool restricted)
142142
/* Expand the possibly-abbreviated filename to an exact path name */
143143
fullname=expand_dynamic_library_name(filename);
144144

145-
/* Load the shared library */
145+
/* Load the shared library, unless we already did */
146146
(void)internal_load_library(fullname);
147147

148148
pfree(fullname);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp