NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7f7fdd2

committed

Make CREATE EXTENSION check schema creation permissions.

When creating a new schema for a non-relocatable extension, we neglectedto check whether the calling user has permission to create schemas.That didn't matter in the original coding, since we had already checkedsuperuserness, but in the new dispensation where users need not besuperusers, we should check it. Use CreateSchemaCommand() rather thancalling NamespaceCreate() directly, so that we also enforce the rulesabout reserved schema names.Per complaint from KaiGai Kohei, though this isn't the same as his patch.

1 parent48f545a commit7f7fdd2Copy full SHA for 7f7fdd2

File tree

1 file changed

+13

-3

lines changed

src/backend/commands
- extension.c

1 file changed

+13

-3

lines changed

`‎src/backend/commands/extension.c`

Lines changed: 13 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@`
`40`	`40`	`#include"commands/alter.h"`
`41`	`41`	`#include"commands/comment.h"`
`42`	`42`	`#include"commands/extension.h"`
	`43`	`+#include"commands/schemacmds.h"`
`43`	`44`	`#include"commands/trigger.h"`
`44`	`45`	`#include"executor/executor.h"`
`45`	`46`	`#include"funcapi.h"`
`@@ -1369,9 +1370,18 @@ CreateExtension(CreateExtensionStmt *stmt)`
`1369`	`1370`
`1370`	`1371`	`if (schemaOid==InvalidOid)`
`1371`	`1372`	`{`
`1372`		`-schemaOid=NamespaceCreate(schemaName,extowner);`
`1373`		`-/* Advance cmd counter to make the namespace visible */`
`1374`		`-CommandCounterIncrement();`
	`1373`	`+CreateSchemaStmt*csstmt=makeNode(CreateSchemaStmt);`
	`1374`	`+`
	`1375`	`+csstmt->schemaname=schemaName;`
	`1376`	`+csstmt->authid=NULL;/* will be created by current user */`
	`1377`	`+csstmt->schemaElts=NIL;`
	`1378`	`+CreateSchemaCommand(csstmt,NULL);`
	`1379`	`+`
	`1380`	`+/*`
	`1381`	`+ * CreateSchemaCommand includes CommandCounterIncrement, so new`
	`1382`	`+ * schema is now visible`
	`1383`	`+ */`
	`1384`	`+schemaOid=get_namespace_oid(schemaName, false);`
`1375`	`1385`	`}`
`1376`	`1386`	`}`
`1377`	`1387`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7f7fdd2

File tree

1 file changed

1 file changed

`‎src/backend/commands/extension.c`

0 commit comments