NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7f17fd6

committed

Fix CompareIndexInfo's attnum comparisons

When an index column is an expression, it makes no sense to compare itsattribute numbers.This seems to account for remaining buildfarm fallout from8b08f7d.At least, it solves the issue in my local 32bit VM -- let's see what therest thinks.

1 parent8b9e964 commit7f17fd6Copy full SHA for 7f17fd6

File tree

1 file changed

-2

lines changed

src/backend/catalog
- index.c

1 file changed

-2

lines changed

`‎src/backend/catalog/index.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1795,8 +1795,10 @@ CompareIndexInfo(IndexInfo info1, IndexInfo info2,`
`1795`	`1795`	`if (maplen<info2->ii_KeyAttrNumbers[i])`
`1796`	`1796`	`elog(ERROR,"incorrect attribute map");`
`1797`	`1797`
`1798`		`-if (attmap[info2->ii_KeyAttrNumbers[i]-1]!=`
`1799`		`-info1->ii_KeyAttrNumbers[i])`
	`1798`	`+/* ignore expressions at this stage */`
	`1799`	`+if ((info1->ii_KeyAttrNumbers[i]!=InvalidAttrNumber)&&`
	`1800`	`+(attmap[info2->ii_KeyAttrNumbers[i]-1]!=`
	`1801`	`+info1->ii_KeyAttrNumbers[i]))`
`1800`	`1802`	`return false;`
`1801`	`1803`
`1802`	`1804`	`if (collations1[i]!=collations2[i])`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7f17fd6

File tree

1 file changed

1 file changed

`‎src/backend/catalog/index.c`

0 commit comments