Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7f0873f

Browse files
committed
Refresh apply delay on reload of recovery_min_apply_delay at recovery
This commit ensures that the wait interval in the replay delay loopwaiting for an amount of time defined by recovery_min_apply_delay iscorrectly handled on reload, recalculating the delay if this GUC valueis updated, based on the timestamp of the commit record being replayed.The previous behavior would be problematic for example with replaystill waiting even if the delay got reduced or just cancelled. If theapply delay was increased to a larger value, the wait would have justrespected the old value set, finishing earlier.Author: Soumyadeep Chakraborty, Ashwin AgrawalReviewed-by: Kyotaro Horiguchi, Michael PaquierDiscussion:https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.comBackpatch-through: 9.6
1 parent48695de commit7f0873f

File tree

1 file changed

+11
-2
lines changed
  • src/backend/access/transam

1 file changed

+11
-2
lines changed

‎src/backend/access/transam/xlog.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6120,14 +6120,23 @@ recoveryApplyDelay(XLogReaderState *record)
61206120
{
61216121
ResetLatch(&XLogCtl->recoveryWakeupLatch);
61226122

6123-
/* might change the trigger file's location */
6123+
/*
6124+
* This might change recovery_min_apply_delay or the trigger file's
6125+
* location.
6126+
*/
61246127
HandleStartupProcInterrupts();
61256128

61266129
if (CheckForStandbyTrigger())
61276130
break;
61286131

61296132
/*
6130-
* Wait for difference between GetCurrentTimestamp() and delayUntil
6133+
* Recalculate delayUntil as recovery_min_apply_delay could have
6134+
* changed while waiting in this loop.
6135+
*/
6136+
delayUntil=TimestampTzPlusMilliseconds(xtime,recovery_min_apply_delay);
6137+
6138+
/*
6139+
* Wait for difference between GetCurrentTimestamp() and delayUntil.
61316140
*/
61326141
msecs=TimestampDifferenceMilliseconds(GetCurrentTimestamp(),
61336142
delayUntil);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp