NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7e4911b

committed

Fix variable confusion in BufferSync().

As noted by Heikki Linnakangas, the previous coding confused the "flags"variable with the "mask" variable. The affect of this appears to be thatunlogged buffers would get written out at every checkpoint rather thanonly at shutdown time. Although that's arguably an acceptable failuremode, I'm back-patching this change, since it seems like a poor idea torely on this happening to work.

1 parentbd0e74a commit7e4911bCopy full SHA for 7e4911b

File tree

1 file changed

-1

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-1

lines changed

`‎src/backend/storage/buffer/bufmgr.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1191,7 +1191,7 @@ BufferSync(int flags)`
`1191`	`1191`	`* buffers. But at shutdown time, we write all dirty buffers.`
`1192`	`1192`	`*/`
`1193`	`1193`	`if (!(flags&CHECKPOINT_IS_SHUTDOWN))`
`1194`		`-flags \|=BM_PERMANENT;`
	`1194`	`+mask \|=BM_PERMANENT;`
`1195`	`1195`
`1196`	`1196`	`/*`
`1197`	`1197`	`* Loop over all buffers, and mark the ones that need to be written with`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7e4911b

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c`

0 commit comments