NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7dc7218

committed

Don't call PageGetSpecialPointer() on page until it's been initialized.

After calling XLogInitBufferForRedo(), the page might be all-zeros if it wasnot in page cache already. btree_xlog_unlink_page initialized the pagecorrectly, but it called PageGetSpecialPointer before initializing it, whichwould lead to a corrupt page at WAL replay, if the unlinked page is not inpage cache.Backpatch to 9.4, the bug came with the rewrite of B-tree page deletion.

1 parent1afc1fe commit7dc7218Copy full SHA for 7dc7218

File tree

1 file changed

-1

lines changed

src/backend/access/nbtree
- nbtxlog.c

1 file changed

-1

lines changed

`‎src/backend/access/nbtree/nbtxlog.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -997,9 +997,10 @@ btree_xlog_unlink_page(uint8 info, XLogRecPtr lsn, XLogRecord *record)`
`997`	`997`	`buffer=XLogReadBuffer(xlrec->node,xlrec->leafblk, true);`
`998`	`998`	`Assert(BufferIsValid(buffer));`
`999`	`999`	`page= (Page)BufferGetPage(buffer);`
`1000`		`-pageop= (BTPageOpaque)PageGetSpecialPointer(page);`
`1001`	`1000`
`1002`	`1001`	`_bt_pageinit(page,BufferGetPageSize(buffer));`
	`1002`	`+pageop= (BTPageOpaque)PageGetSpecialPointer(page);`
	`1003`	`+`
`1003`	`1004`	`pageop->btpo_flags=BTP_HALF_DEAD \|BTP_LEAF;`
`1004`	`1005`	`pageop->btpo_prev=xlrec->leafleftsib;`
`1005`	`1006`	`pageop->btpo_next=xlrec->leafrightsib;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7dc7218

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtxlog.c`

0 commit comments