NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7d9309f

committed

Allow NumericOnly to be "+ FCONST".

The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST,FCONST, and - FCONST, but for some reason not + FCONST. This led tostrange inconsistencies likeregression=# set random_page_cost = +4;SETregression=# set random_page_cost = 4000000000;SETregression=# set random_page_cost = +4000000000;ERROR: syntax error at or near "4000000000"(because 4000000000 is too large to be an ICONST). While there'sno actual functional reason to need to write a "+", if we allowit for integers it seems like we should allow it for numerics too.It's been like that forever, so back-patch to all supported branches.Discussion:https://postgr.es/m/30908.1496006184@sss.pgh.pa.us

1 parent525780c commit7d9309fCopy full SHA for 7d9309f

File tree

1 file changed

-0

lines changed

src/backend/parser
- gram.y

1 file changed

-0

lines changed

`‎src/backend/parser/gram.y`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3396,6 +3396,7 @@ opt_by:BY{}`
`3396`	`3396`
`3397`	`3397`	`NumericOnly:`
`3398`	`3398`	`FCONST{$$ = makeFloat($1); }`
	`3399`	`+\|'+'FCONST{$$ = makeFloat($2); }`
`3399`	`3400`	`\|'-'FCONST`
`3400`	`3401`	`{`
`3401`	`3402`	`$$ = makeFloat($2);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7d9309f

File tree

1 file changed

1 file changed

`‎src/backend/parser/gram.y`

0 commit comments