NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7d88bb7

committed

Add some temporary instrumentation to pgstat.c.

Log main-loop blocking events and the results of inquiry messages.This is to get some clarity as to what's happening on those Windowsbuildfarm members that still don't like the latch-ified stats collector.This bulks up the postmaster log a tad, so I won't leave it in place forlong.

1 parentb834713 commit7d88bb7Copy full SHA for 7d88bb7

File tree

1 file changed

+20

-0

lines changed

src/backend/postmaster
- pgstat.c

1 file changed

+20

-0

lines changed

`‎src/backend/postmaster/pgstat.c`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3107,7 +3107,12 @@ PgstatCollectorMain(int argc, char *argv[])`
`3107`	`3107`	`* satisfied by existing file.`
`3108`	`3108`	`*/`
`3109`	`3109`	`if (last_statwrite<last_statrequest)`
	`3110`	`+{`
	`3111`	`+elog(LOG,"pgstat: writing new stats file");`
`3110`	`3112`	`pgstat_write_statsfile(false);`
	`3113`	`+}`
	`3114`	`+`
	`3115`	`+elog(LOG,"pgstat: attempting recv()");`
`3111`	`3116`
`3112`	`3117`	`/*`
`3113`	`3118`	`* Try to receive and process a message. This will not block,`
`@@ -3124,6 +3129,9 @@ PgstatCollectorMain(int argc, char *argv[])`
`3124`	`3129`	`errmsg("could not read statistics message: %m")));`
`3125`	`3130`	`}`
`3126`	`3131`
	`3132`	`+elog(LOG,"pgstat: received msg type %d len %d",`
	`3133`	`+msg.msg_hdr.m_type,len);`
	`3134`	`+`
`3127`	`3135`	`/*`
`3128`	`3136`	`* We ignore messages that are smaller than our common header`
`3129`	`3137`	`*/`
`@@ -3218,12 +3226,16 @@ PgstatCollectorMain(int argc, char *argv[])`
`3218`	`3226`	`}`
`3219`	`3227`	`}/* end of inner message-processing loop */`
`3220`	`3228`
	`3229`	`+elog(LOG,"pgstat: waiting");`
	`3230`	`+`
`3221`	`3231`	`/* Sleep until there's something to do */`
`3222`	`3232`	`wr=WaitLatchOrSocket(&pgStatLatch,`
`3223`	`3233`	`WL_LATCH_SET \|WL_POSTMASTER_DEATH \|WL_SOCKET_READABLE,`
`3224`	`3234`	`pgStatSock,`
`3225`	`3235`	`-1L);`
`3226`	`3236`
	`3237`	`+elog(LOG,"pgstat: wait result 0x%x",wr);`
	`3238`	`+`
`3227`	`3239`	`/*`
`3228`	`3240`	`* Emergency bailout if postmaster has died. This is to avoid the`
`3229`	`3241`	`* necessity for manual cleanup of all postmaster children.`
`@@ -4006,7 +4018,15 @@ static void`
`4006`	`4018`	`pgstat_recv_inquiry(PgStat_MsgInquiry*msg,intlen)`
`4007`	`4019`	`{`
`4008`	`4020`	`if (msg->inquiry_time>last_statrequest)`
	`4021`	`+{`
`4009`	`4022`	`last_statrequest=msg->inquiry_time;`
	`4023`	`+if (last_statwrite<last_statrequest)`
	`4024`	`+elog(LOG,"pgstat: received new inquiry message");`
	`4025`	`+else`
	`4026`	`+elog(LOG,"pgstat: received stale inquiry message");`
	`4027`	`+}`
	`4028`	`+else`
	`4029`	`+elog(LOG,"pgstat: received out-of-order inquiry message");`
`4010`	`4030`	`}`
`4011`	`4031`
`4012`	`4032`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7d88bb7

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/pgstat.c`

0 commit comments