forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit7d6d2c4
committed
Drop opcintype from index AM strategy translation API
The type argument wasn't actually really necessary. It was a remnantof converting the API of the gist strategy translation from usingopclass to using opfamily+opcintype (commitsc09e5a6,622f678). For looking up the gist translation function, we usedthe convention "amproclefttype = amprocrighttype = opclass'sopcintype" (see pg_amproc.h). But each operator family should onlyhave one translation function, and getting the right type for thelookup is sometimes cumbersome and fragile, so this is allunnecessarily complicated.To simplify this, change the gist stategy support procedure to take"any", "any" as argument. (This is arbitrary but seems intuitive.The alternative of using InvalidOid as argument(s) upsets various DDLcommands, so it's not practical.) Then we don't need opcintype forthe lookup, and we can remove it from all the API layers introduced bycommitc09e5a6.This also adds some more documentation about the correct signature ofthe gist support function and adds more checks in gistvalidate().This was previously underspecified. (It relied implicitly onconvention mentioned above.)Discussion:https://www.postgresql.org/message-id/flat/E72EAA49-354D-4C2E-8EB9-255197F55330@enterprisedb.com1 parent7202d72 commit7d6d2c4
File tree
18 files changed
+72
-67
lines changed- contrib/btree_gist
- doc/src/sgml
- src
- backend
- access
- gist
- hash
- index
- nbtree
- catalog
- commands
- executor
- replication/logical
- include
- access
- catalog
18 files changed
+72
-67
lines changedLines changed: 26 additions & 26 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
9 | 9 |
| |
10 | 10 |
| |
11 | 11 |
| |
12 |
| - | |
| 12 | + | |
13 | 13 |
| |
14 | 14 |
| |
15 |
| - | |
| 15 | + | |
16 | 16 |
| |
17 | 17 |
| |
18 |
| - | |
| 18 | + | |
19 | 19 |
| |
20 | 20 |
| |
21 |
| - | |
| 21 | + | |
22 | 22 |
| |
23 | 23 |
| |
24 |
| - | |
| 24 | + | |
25 | 25 |
| |
26 | 26 |
| |
27 |
| - | |
| 27 | + | |
28 | 28 |
| |
29 | 29 |
| |
30 |
| - | |
| 30 | + | |
31 | 31 |
| |
32 | 32 |
| |
33 |
| - | |
| 33 | + | |
34 | 34 |
| |
35 | 35 |
| |
36 |
| - | |
| 36 | + | |
37 | 37 |
| |
38 | 38 |
| |
39 |
| - | |
| 39 | + | |
40 | 40 |
| |
41 | 41 |
| |
42 |
| - | |
| 42 | + | |
43 | 43 |
| |
44 | 44 |
| |
45 |
| - | |
| 45 | + | |
46 | 46 |
| |
47 | 47 |
| |
48 |
| - | |
| 48 | + | |
49 | 49 |
| |
50 | 50 |
| |
51 |
| - | |
| 51 | + | |
52 | 52 |
| |
53 | 53 |
| |
54 |
| - | |
| 54 | + | |
55 | 55 |
| |
56 | 56 |
| |
57 |
| - | |
| 57 | + | |
58 | 58 |
| |
59 | 59 |
| |
60 |
| - | |
| 60 | + | |
61 | 61 |
| |
62 | 62 |
| |
63 |
| - | |
| 63 | + | |
64 | 64 |
| |
65 | 65 |
| |
66 |
| - | |
| 66 | + | |
67 | 67 |
| |
68 | 68 |
| |
69 |
| - | |
| 69 | + | |
70 | 70 |
| |
71 | 71 |
| |
72 |
| - | |
| 72 | + | |
73 | 73 |
| |
74 | 74 |
| |
75 |
| - | |
| 75 | + | |
76 | 76 |
| |
77 | 77 |
| |
78 |
| - | |
| 78 | + | |
79 | 79 |
| |
80 | 80 |
| |
81 |
| - | |
| 81 | + | |
82 | 82 |
| |
83 | 83 |
| |
84 |
| - | |
| 84 | + | |
85 | 85 |
| |
86 | 86 |
| |
87 |
| - | |
| 87 | + |
Lines changed: 6 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1197 | 1197 |
| |
1198 | 1198 |
| |
1199 | 1199 |
| |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
1200 | 1206 |
| |
1201 | 1207 |
| |
1202 | 1208 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1095 | 1095 |
| |
1096 | 1096 |
| |
1097 | 1097 |
| |
1098 |
| - | |
| 1098 | + | |
1099 | 1099 |
| |
1100 | 1100 |
| |
1101 | 1101 |
| |
1102 | 1102 |
| |
1103 | 1103 |
| |
1104 |
| - | |
| 1104 | + | |
1105 | 1105 |
| |
1106 | 1106 |
| |
1107 | 1107 |
| |
|
Lines changed: 3 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
140 | 140 |
| |
141 | 141 |
| |
142 | 142 |
| |
143 |
| - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
144 | 146 |
| |
145 | 147 |
| |
146 | 148 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
927 | 927 |
| |
928 | 928 |
| |
929 | 929 |
| |
930 |
| - | |
| 930 | + | |
931 | 931 |
| |
932 | 932 |
| |
933 | 933 |
| |
934 | 934 |
| |
935 | 935 |
| |
936 | 936 |
| |
937 | 937 |
| |
938 |
| - | |
| 938 | + | |
939 | 939 |
| |
940 | 940 |
| |
941 | 941 |
| |
|
Lines changed: 4 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
115 | 115 |
| |
116 | 116 |
| |
117 | 117 |
| |
118 |
| - | |
| 118 | + | |
119 | 119 |
| |
120 | 120 |
| |
121 | 121 |
| |
122 | 122 |
| |
123 | 123 |
| |
124 | 124 |
| |
125 |
| - | |
| 125 | + | |
126 | 126 |
| |
127 | 127 |
| |
128 | 128 |
| |
| |||
140 | 140 |
| |
141 | 141 |
| |
142 | 142 |
| |
143 |
| - | |
| 143 | + | |
144 | 144 |
| |
145 | 145 |
| |
146 | 146 |
| |
147 | 147 |
| |
148 | 148 |
| |
149 | 149 |
| |
150 |
| - | |
| 150 | + | |
151 | 151 |
| |
152 | 152 |
| |
153 | 153 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1513 | 1513 |
| |
1514 | 1514 |
| |
1515 | 1515 |
| |
1516 |
| - | |
| 1516 | + | |
1517 | 1517 |
| |
1518 | 1518 |
| |
1519 | 1519 |
| |
| |||
1533 | 1533 |
| |
1534 | 1534 |
| |
1535 | 1535 |
| |
1536 |
| - | |
| 1536 | + | |
1537 | 1537 |
| |
1538 | 1538 |
| |
1539 | 1539 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2692 | 2692 |
| |
2693 | 2693 |
| |
2694 | 2694 |
| |
2695 |
| - | |
2696 | 2695 |
| |
2697 | 2696 |
| |
2698 | 2697 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2468 | 2468 |
| |
2469 | 2469 |
| |
2470 | 2470 |
| |
2471 |
| - | |
| 2471 | + | |
2472 | 2472 |
| |
2473 | 2473 |
| |
2474 | 2474 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
10113 | 10113 |
| |
10114 | 10114 |
| |
10115 | 10115 |
| |
10116 |
| - | |
| 10116 | + | |
10117 | 10117 |
| |
10118 | 10118 |
| |
10119 | 10119 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
91 | 91 |
| |
92 | 92 |
| |
93 | 93 |
| |
94 |
| - | |
| 94 | + | |
95 | 95 |
| |
96 | 96 |
| |
97 | 97 |
| |
|
Lines changed: 2 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
837 | 837 |
| |
838 | 838 |
| |
839 | 839 |
| |
840 |
| - | |
841 | 840 |
| |
842 |
| - | |
843 |
| - | |
844 |
| - | |
| 841 | + | |
| 842 | + | |
845 | 843 |
| |
846 | 844 |
| |
847 | 845 |
| |
|
Lines changed: 4 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
102 | 102 |
| |
103 | 103 |
| |
104 | 104 |
| |
105 |
| - | |
| 105 | + | |
106 | 106 |
| |
107 | 107 |
| |
108 |
| - | |
| 108 | + | |
109 | 109 |
| |
110 | 110 |
| |
111 | 111 |
| |
| |||
319 | 319 |
| |
320 | 320 |
| |
321 | 321 |
| |
322 |
| - | |
323 |
| - | |
| 322 | + | |
| 323 | + | |
324 | 324 |
| |
325 | 325 |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
248 | 248 |
| |
249 | 249 |
| |
250 | 250 |
| |
251 |
| - | |
| 251 | + | |
252 | 252 |
| |
253 | 253 |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
387 | 387 |
| |
388 | 388 |
| |
389 | 389 |
| |
390 |
| - | |
391 |
| - | |
| 390 | + | |
| 391 | + | |
392 | 392 |
| |
393 | 393 |
| |
394 | 394 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1183 | 1183 |
| |
1184 | 1184 |
| |
1185 | 1185 |
| |
1186 |
| - | |
1187 |
| - | |
| 1186 | + | |
| 1187 | + | |
1188 | 1188 |
| |
1189 | 1189 |
| |
1190 | 1190 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
57 | 57 |
| |
58 | 58 |
| |
59 | 59 |
| |
60 |
| - | |
| 60 | + | |
61 | 61 |
| |
62 | 62 |
|
Lines changed: 12 additions & 12 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
506 | 506 |
| |
507 | 507 |
| |
508 | 508 |
| |
509 |
| - | |
510 |
| - | |
| 509 | + | |
| 510 | + | |
511 | 511 |
| |
512 | 512 |
| |
513 | 513 |
| |
| |||
528 | 528 |
| |
529 | 529 |
| |
530 | 530 |
| |
531 |
| - | |
532 |
| - | |
| 531 | + | |
| 532 | + | |
533 | 533 |
| |
534 | 534 |
| |
535 | 535 |
| |
| |||
549 | 549 |
| |
550 | 550 |
| |
551 | 551 |
| |
552 |
| - | |
553 |
| - | |
| 552 | + | |
| 553 | + | |
554 | 554 |
| |
555 | 555 |
| |
556 | 556 |
| |
| |||
606 | 606 |
| |
607 | 607 |
| |
608 | 608 |
| |
609 |
| - | |
610 |
| - | |
| 609 | + | |
| 610 | + | |
611 | 611 |
| |
612 | 612 |
| |
613 | 613 |
| |
| |||
625 | 625 |
| |
626 | 626 |
| |
627 | 627 |
| |
628 |
| - | |
629 |
| - | |
| 628 | + | |
| 629 | + | |
630 | 630 |
| |
631 | 631 |
| |
632 | 632 |
| |
| |||
646 | 646 |
| |
647 | 647 |
| |
648 | 648 |
| |
649 |
| - | |
650 |
| - | |
| 649 | + | |
| 650 | + | |
651 | 651 |
| |
652 | 652 |
| |
653 | 653 |
| |
|
0 commit comments
Comments
(0)