Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7d60e41

Browse files
committed
Remove useless lstat() call in pg_rewind.
This is duplicative of an lstat that was just done by the callingfunction (traverse_datadir), besides which we weren't really doinganything with the results. There's not much point in checking tosee if someone removed the file since the previous lstat, since theFILE_ACTION_REMOVE code would have to deal with missing-file casesanyway. Moreover, the "exists = false" assignment was a dead store;nothing was done with that value later.A syscall saved is a syscall earned, so back-patch to 9.5where this code was introduced.Discussion:https://postgr.es/m/1221796.1599329320@sss.pgh.pa.us
1 parent546479f commit7d60e41

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

‎src/bin/pg_rewind/filemap.c‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -253,23 +253,11 @@ process_target_file(const char *path, file_type_t type, size_t oldsize,
253253
constchar*link_target)
254254
{
255255
boolexists;
256-
charlocalpath[MAXPGPATH];
257-
structstatstatbuf;
258256
file_entry_tkey;
259257
file_entry_t*key_ptr;
260258
filemap_t*map=filemap;
261259
file_entry_t*entry;
262260

263-
snprintf(localpath,sizeof(localpath),"%s/%s",datadir_target,path);
264-
if (lstat(localpath,&statbuf)<0)
265-
{
266-
if (errno!=ENOENT)
267-
pg_fatal("could not stat file \"%s\": %s\n",
268-
localpath,strerror(errno));
269-
270-
exists= false;
271-
}
272-
273261
if (map->array==NULL)
274262
{
275263
/* on first call, initialize lookup array */

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp