NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7d23381

committed

Remove redundant function calls in timestamp[tz]_part().

The DTK_DOW/DTK_ISODOW and DTK_DOY switch cases in timestamp_part() andtimestamptz_part() contained calls of timestamp2tm() that were fullyredundant with the ones done just above the switch. This evidently creptin during commit258ee1b, which relocated that code from another placewhere the calls were indeed needed. Just delete the redundant calls.I (tgl) noted that our test coverage of these functions left quite abit to be desired, so extend timestamp.sql and timestamptz.sql tocover all the branches.Back-patch to all supported branches, as the previous commit was.There's no real issue here other than some wasted cycles in somenot-too-heavily-used code paths, but the test coverage seems valuable.Report and patch by Li Japin; test case adjustments by me.Discussion:https://postgr.es/m/SG2PR06MB37762CAE45DB0F6CA7001EA9B6550@SG2PR06MB3776.apcprd06.prod.outlook.com

1 parentd94766a commit7d23381Copy full SHA for 7d23381

File tree

5 files changed

+693

-395

lines changed

src
- backend/utils/adt
  - timestamp.c
- test/regress
  - expected
    - timestamp.out
    - timestamptz.out
  - sql
    - timestamp.sql
    - timestamptz.sql

5 files changed

+693

-395

lines changed

`‎src/backend/utils/adt/timestamp.c`

Lines changed: 0 additions & 16 deletions

Original file line number	Diff line number	Diff line change
`@@ -4543,20 +4543,12 @@ timestamp_part(PG_FUNCTION_ARGS)`
`4543`	`4543`
`4544`	`4544`	`caseDTK_DOW:`
`4545`	`4545`	`caseDTK_ISODOW:`
`4546`		`-if (timestamp2tm(timestamp,NULL,tm,&fsec,NULL,NULL)!=0)`
`4547`		`-ereport(ERROR,`
`4548`		`-(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),`
`4549`		`-errmsg("timestamp out of range")));`
`4550`	`4546`	`result=j2day(date2j(tm->tm_year,tm->tm_mon,tm->tm_mday));`
`4551`	`4547`	`if (val==DTK_ISODOW&&result==0)`
`4552`	`4548`	`result=7;`
`4553`	`4549`	`break;`
`4554`	`4550`
`4555`	`4551`	`caseDTK_DOY:`
`4556`		`-if (timestamp2tm(timestamp,NULL,tm,&fsec,NULL,NULL)!=0)`
`4557`		`-ereport(ERROR,`
`4558`		`-(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),`
`4559`		`-errmsg("timestamp out of range")));`
`4560`	`4552`	`result= (date2j(tm->tm_year,tm->tm_mon,tm->tm_mday)`
`4561`	`4553`	`-date2j(tm->tm_year,1,1)+1);`
`4562`	`4554`	`break;`
`@@ -4747,20 +4739,12 @@ timestamptz_part(PG_FUNCTION_ARGS)`
`4747`	`4739`
`4748`	`4740`	`caseDTK_DOW:`
`4749`	`4741`	`caseDTK_ISODOW:`
`4750`		`-if (timestamp2tm(timestamp,&tz,tm,&fsec,NULL,NULL)!=0)`
`4751`		`-ereport(ERROR,`
`4752`		`-(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),`
`4753`		`-errmsg("timestamp out of range")));`
`4754`	`4742`	`result=j2day(date2j(tm->tm_year,tm->tm_mon,tm->tm_mday));`
`4755`	`4743`	`if (val==DTK_ISODOW&&result==0)`
`4756`	`4744`	`result=7;`
`4757`	`4745`	`break;`
`4758`	`4746`
`4759`	`4747`	`caseDTK_DOY:`
`4760`		`-if (timestamp2tm(timestamp,&tz,tm,&fsec,NULL,NULL)!=0)`
`4761`		`-ereport(ERROR,`
`4762`		`-(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),`
`4763`		`-errmsg("timestamp out of range")));`
`4764`	`4748`	`result= (date2j(tm->tm_year,tm->tm_mon,tm->tm_mday)`
`4765`	`4749`	`-date2j(tm->tm_year,1,1)+1);`
`4766`	`4750`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7d23381

File tree

5 files changed

5 files changed

`‎src/backend/utils/adt/timestamp.c`

0 commit comments