Commit7c4d3fe

committed

ecpg: Refactor ecpg_log() to skip unnecessary calls to ECPGget_sqlca().

Previously, ecpg_log() always called ECPGget_sqlca() to retrieve sqlca,even though it was only needed for debug logging. This commit updatesecpg_log() to call ECPGget_sqlca() only when debug logging is enabled.Author: Yuto SasakiReviewed-by: Alvaro Herrera, Tom Lane, Fujii MasaoDiscussion:https://postgr.es/m/TY2PR01MB3628A85689649BABC9A1C6C3C1782@TY2PR01MB3628.jpnprd01.prod.outlook.com

1 parent53af949 commit7c4d3feCopy full SHA for 7c4d3fe

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -232,10 +232,10 @@ void`
`232`	`232`	`ecpg_log(constchar*format,...)`
`233`	`233`	`{`
`234`	`234`	`va_listap;`
`235`		`-structsqlca_t*sqlca=ECPGget_sqlca();`
`236`	`235`	`constchar*intl_format;`
`237`	`236`	`intbufsize;`
`238`	`237`	`char*fmt;`
	`238`	`+structsqlca_t*sqlca;`
`239`	`239`
`240`	`240`	`/*`
`241`	`241`	`* For performance reasons, inspect simple_debug without taking the mutex.`
`@@ -262,6 +262,8 @@ ecpg_log(const char *format,...)`
`262`	`262`	`else`
`263`	`263`	`snprintf(fmt,bufsize,"[%d]: %s", (int)getpid(),intl_format);`
`264`	`264`
	`265`	`+sqlca=ECPGget_sqlca();`
	`266`	`+`
`265`	`267`	`pthread_mutex_lock(&debug_mutex);`
`266`	`268`
`267`	`269`	`/* Now that we hold the mutex, recheck simple_debug */`

Comments

(0)