NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7c19e04

committed

Remove unnecessary AssertMacro() to suppress gcc 4.6 compiler warning.

There's no particular value in doing AssertMacro((tup) != NULL) in frontof code that's certain to crash anyway if tup is NULL. And if "tup" isactually the address of a local variable, gcc 4.6 whinges about it. That'sarguably pretty broken on gcc's part, but we might as well remove theuseless test to silence the warnings. This gets rid of all the -Waddresswarnings in the backend; there are some in libpq and psql that are a bitharder to avoid.

1 parentb246207 commit7c19e04Copy full SHA for 7c19e04

File tree

1 file changed

-4

lines changed

src/include/access
- htup.h

1 file changed

-4

lines changed

`‎src/include/access/htup.h`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -839,8 +839,6 @@ extern Datum fastgetattr(HeapTuple tup, int attnum, TupleDesc tupleDesc,`
`839`	`839`	`* ----------------`
`840`	`840`	`*/`
`841`	`841`	`#defineheap_getattr(tup,attnum,tupleDesc,isnull) \`
`842`		`-( \`
`843`		`-AssertMacro((tup) != NULL), \`
`844`	`842`	`( \`
`845`	`843`	`((attnum) > 0) ? \`
`846`	`844`	`( \`
`@@ -854,8 +852,7 @@ extern Datum fastgetattr(HeapTuple tup, int attnum, TupleDesc tupleDesc,`
`854`	`852`	`) \`
`855`	`853`	`: \`
`856`	`854`	`heap_getsysattr((tup), (attnum), (tupleDesc), (isnull)) \`
`857`		`-) \`
`858`		`-)`
	`855`	`+)`
`859`	`856`
`860`	`857`	`/* prototypes for functions in common/heaptuple.c */`
`861`	`858`	`externSizeheap_compute_data_size(TupleDesctupleDesc,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7c19e04

File tree

1 file changed

1 file changed

`‎src/include/access/htup.h`

0 commit comments